Add compatibility with django 1.11 #8
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It has been deprecated in Django 1.3 and removed in Django 1.6
It has been deprecated in Django 1.8 and removed in Django 1.11 See https://docs.djangoproject.com/en/1.11/releases/1.8/#django-conf-urls-patterns
zorun
force-pushed
the
towards-django-1.11
branch
from
08483f5 to
508e537
Compare
added 3 commits
May 22, 2017 23:30
This has been deprecated in Django 1.8 and removed in Django 1.10 See https://docs.djangoproject.com/en/1.11/releases/1.8/#passing-a-dotted-path-to-reverse-and-url
zorun
force-pushed
the
towards-django-1.11
branch
from
2d82eb6 to
5522c42
Compare
added 4 commits
May 22, 2017 23:49
The old syntax has been deprecated in Django 1.8 and does not work anymore with Django 1.11. See https://docs.djangoproject.com/en/1.11/releases/1.8/#dictionary-and-context-instance-arguments-of-rendering-functions
It has been deprecated in Django 1.7 and removed in Django 1.9 See https://docs.djangoproject.com/en/1.11/releases/1.7/#loading-ssi-and-url-template-tags-from-future-library
…jango's User model
This is better, because it allows django_sshkey to be used in projects
that use a custom User model:
https://docs.djangoproject.com/en/1.11/topics/auth/customizing/#referencing-the-user-model
Note that there is no migration needed with this change, since the first
migration apparently already references settings.AUTH_USER_MODEL.
on_delete currently defaults to CASCADE (so, there is no functional change), but this will become a required argument in Django 2.0. See https://docs.djangoproject.com/en/1.11/ref/models/fields/#django.db.models.ForeignKey.on_delete Again, no migration is necessary here, because this is the default value.
|
For your information, I forked your project, the result is here: https://github.com/zorun/django-simplesshkey/ It's not a "hostile" fork. I simply ran into limitations of django_sshkey, because I have simpler needs. More details here: https://github.com/zorun/django-simplesshkey/#about-django-sshkey-and-django-simplesshkey Feel free to merge this PR anyway, others may benefit from Django 1.11 support :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This django package is now compatible with Django 1.8, 1.9, 1.10 and 1.11.