WEB-3536: fetch api changes #368

AshwinSaxena01 · 2025-03-06T10:38:38Z

Changes

WEB-3536: Added enableFetchApi flag to conditionally use fetch instead of script injection for firing requests. This flag can be controlled by user while initialising SDK. When flag is missing - default behaviour is script injection for backward compatibility

Changes to Public Facing API if any

Please list the impact on the public facing API if any

How Has This Been Tested?

Cases -

Flag is set to true.
Flag is set to false.
Flag is undefined.
Each case tested for shopify as well.

Describe the testing approach and any relevant configurations (e.g., environment, platform)
Overriding SDK

Checklist

Code compiles without errors
Version Bump added to package.json & CHANGELOG.md
All tests pass
Build process is successful
Documentation has been updated (if needed)

coderabbitai · 2025-03-06T10:38:45Z

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

✨ Finishing Touches

🧪 Generate unit tests

Create PR with unit tests
Post copyable unit tests in a comment
Commit unit tests in branch fetch-api

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

Review comments: Directly reply to a review comment made by CodeRabbit. Example:
- I pushed a fix in commit <commit_id>, please review it.
- Open a follow-up GitHub issue for this discussion.
Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query.
PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
- @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
- @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

CodeRabbit Commands (Invoked using PR/Issue comments)

Type @coderabbitai help to get the list of available commands.

Other keywords and placeholders

Add @coderabbitai ignore or @coderabbit ignore anywhere in the PR description to prevent this PR from being reviewed.
Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (`.coderabbit.yaml`)

You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
Please see the configuration documentation for more information.
If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Status, Documentation and Community

Visit our Status Page to check the current availability of CodeRabbit.
Visit our Documentation for detailed information on how to use CodeRabbit.
Join our Discord Community to get help, request features, and share feedback.
Follow us on X/Twitter for updates and announcements.

singhkunal2050 · 2025-03-13T08:28:06Z

src/clevertap.js

-  init (accountId, region, targetDomain, token, antiFlicker = {}) {
-    if (Object.keys(antiFlicker).length > 0) {
-      addAntiFlicker(antiFlicker)
+  init (accountId, region, targetDomain, token, config = { antiFlicker: {} }) {


This is a breaking change, please add a new param config and do not change the existing function param.

Not being used by anyone currently, confirmed it with @ThisIsRaghavGupta

Before removing it please get a go ahead from the PM. In case we have evidence of no usage we can get rid of it otherwise we have to introduce new argument.

yeah already confirmed this

singhkunal2050 · 2025-03-13T08:30:15Z

src/util/requestDispatcher.js

+      document.getElementsByTagName('head')[0].appendChild(s)
+      this.logger.debug('req snt -> url: ' + url)
+    } else {
+      try {


Create a function handle Fetch response here and use it

singhkunal2050 · 2025-03-13T09:10:07Z

src/util/requestDispatcher.js

+      }
+      this.logger.debug('req snt -> url: ' + url)
+    } catch (error) {
+      console.error('Fetch error:', error)


Use logger.error

singhkunal2050 · 2025-03-13T09:10:31Z

src/util/requestDispatcher.js

+        throw new Error(`Network response was not ok: ${response.statusText}`)
+      }
+      const jsonResponse = await response.json()
+      console.log('Response received:', jsonResponse)


Use logger.debug

removed this

francispereira · 2025-06-24T07:11:48Z

🎉 Snyk checks have passed. No issues have been found so far.

✅ security/snyk check is complete. No issues have been found. (View Details)

✅ license/snyk check is complete. No issues have been found. (View Details)

✅ code/snyk check is complete. No issues have been found. (View Details)

src/clevertap.js

…fetch-api

fetch api changes

3afb547

AshwinSaxena01 added 3 commits March 6, 2025 17:24

added enableFetchApi flag

3b74737

Merge branch 'develop' into fetch-api

b228081

latest builds

17c14e4

AshwinSaxena01 changed the base branch from master to develop March 7, 2025 08:33

AshwinSaxena01 added 4 commits March 10, 2025 11:00

getter setter for enableFetchApi

2e4f83f

refactored init and added global var

ae3dc60

reverted token config change

d97c1d8

fixed typo

d15da53

singhkunal2050 requested changes Mar 13, 2025

View reviewed changes

added handleFetchResponse method

f2b2b98

AshwinSaxena01 changed the title ~~fetch api changes~~ WEB-3536: fetch api changes Mar 13, 2025

AshwinSaxena01 requested a review from singhkunal2050 March 13, 2025 09:29

singhkunal2050 reviewed Mar 13, 2025

View reviewed changes

added logger

fed3ee2

singhkunal2050 mentioned this pull request Apr 30, 2025

[WEB-3694] Custom CT ID & Get All Qualified Campaigns #408

Merged

5 tasks

Merge branch 'develop' into fetch-api

468141d

singhkunal2050 self-requested a review June 10, 2025 08:49

Updated jest.config to handle async and await

b298c47

KambleSonam added 2 commits June 25, 2025 13:35

Fixed the spec files

4712430

reverted jest.config.js file

5971458

singhkunal2050 marked this pull request as ready for review July 2, 2025 09:44

singhkunal2050 requested a review from a team as a code owner July 2, 2025 09:44

Merge remote-tracking branch 'origin/develop' into fetch-api

b771d50

singhkunal2050 requested changes Jul 14, 2025

View reviewed changes

src/clevertap.js Show resolved Hide resolved

singhkunal2050 self-requested a review July 14, 2025 06:18

KambleSonam added 2 commits July 14, 2025 12:32

meta obj update

3c951a7

Merge remote-tracking branch 'origin/develop' into fetch-api

d4d8177

KambleSonam and others added 11 commits July 18, 2025 13:02

Merge remote-tracking branch 'origin/develop' into fetch-api

a8b8612

corrected parsing of rn in meta

945be5b

changed logs from console to logger in Variablestore

b1f4faf

updated build files

daabb8c

Merge remote-tracking branch 'origin/develop' into fetch-api

1d3bf9b

Updated changelog

00f1fff

SDK Release 2.2.0 (#463)

a301e9f

Merge branch 'master' of github.com:CleverTap/clevertap-web-sdk into …

0ea74b7

…fetch-api

fix: removed $ct dependency

109f4ff

removed async await

d47d5c6

added new build files

a75f261

WEB-3536: fetch api changes #368

Are you sure you want to change the base?

WEB-3536: fetch api changes #368

Uh oh!

Conversation

AshwinSaxena01 commented Mar 6, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Changes

Changes to Public Facing API if any

How Has This Been Tested?

Checklist

Uh oh!

coderabbitai bot commented Mar 6, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Review skipped

Chat

Support

CodeRabbit Commands (Invoked using PR/Issue comments)

Other keywords and placeholders

CodeRabbit Configuration File (.coderabbit.yaml)

Status, Documentation and Community

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

francispereira commented Jun 24, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

🎉 Snyk checks have passed. No issues have been found so far.

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

AshwinSaxena01 commented Mar 6, 2025 •

edited

Loading

coderabbitai bot commented Mar 6, 2025 •

edited

Loading

CodeRabbit Configuration File (`.coderabbit.yaml`)

francispereira commented Jun 24, 2025 •

edited

Loading