-
Couldn't load subscription status.
- Fork 19
[WEB-3694] Custom CT ID & Get All Qualified Campaigns #408
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
9 commits
Select commit
Hold shift + click to select a range
3c3586d
[WEB-3694] Custom CT ID & Get All Qualified Campaigns
singhkunal2050 cefe652
[WEB-3694] Custom CT ID - WIP
singhkunal2050 7885d85
[WEB-3694] Custom CT-ID - Fixed Unit Tests Failures
singhkunal2050 e0afddc
Merge branch 'develop' into WEB-3694
singhkunal2050 696793b
[WEB-3694] Custom CT-ID - Rebased
singhkunal2050 345ef7d
Added Unit Tests & Review Comments
singhkunal2050 70ef620
Review Comments
singhkunal2050 9712ecc
Version Bump
singhkunal2050 fc71cef
Review Comments
singhkunal2050 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Large diffs are not rendered by default.
Oops, something went wrong.
Large diffs are not rendered by default.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Harden local-storage deserialisation & enforce a retention policy.
decodeURIComponentandJSON.parsewill throw if the stored value is malformed (e.g. user manually clears part of the cookie). A defensive wrapper avoids cascading failures:Optional: cap the array length (e.g. 50) before saving to respect storage limits (see previous comment).
📝 Committable suggestion