Open
Conversation
ph-kev
force-pushed
the
kp/compute-schedule
branch
from
db28c9a to
37c26c3
Compare
szy21
reviewed
Feb 2, 2026
| return EveryStepSchedule() | ||
| end | ||
|
|
||
| is_precip_diag = model isa Union{EquilMoistModel, NonEquilMoistModel} |
Member
There was a problem hiding this comment.
Is this making only the precipitation and radiation diagnostics 1h, or is it making all the variables in a simulation running with EquilMoistModel or NonEquilMoistModel or AbstractRRTMGPMode 1h?
Member
Author
There was a problem hiding this comment.
It is the latter. I can make it only the precipitation and radiation diagnostics 1h if this solution isn't okay.
Member
There was a problem hiding this comment.
Yes we want only the precipitation and radiation diagnostics 1h. But if it's complicated, just making everything 1h is fine.
ph-kev
force-pushed
the
kp/compute-schedule
branch
from
37c26c3 to
5f2539a
Compare
ph-kev
force-pushed
the
kp/compute-schedule
branch
2 times, most recently
from
abaf2f4 to
6b76a47
Compare
ph-kev
force-pushed
the
kp/compute-schedule
branch
from
6b76a47 to
caf92d5
Compare
ph-kev
force-pushed
the
kp/compute-schedule
branch
from
caf92d5 to
5a3440e
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
close #4253 - This PR changes the default compute schedule from
EveryStepScheduleto a frequency of six hours for most diagnostics. For precipitation and radiation diagnostics, the frequency is one hour.