use TripolarGrid, ConservativeRegridding#1679
Open
juliasloan25 wants to merge 37 commits intomainfrom
Open
Conversation
26815d5 to
c4d1688
Compare
…limaCoupler.jl into js/tripolar-conservative-jan2026
0135836 to
b1db80e
Compare
3d752c0 to
accc24a
Compare
juliasloan25
commented
Jan 28, 2026
juliasloan25
commented
Jan 28, 2026
…limaCoupler.jl into js/tripolar-conservative-jan2026
juliasloan25
commented
Jan 29, 2026
6ba52ad to
e495d4f
Compare
520376c to
9ecd8ee
Compare
juliasloan25
commented
Feb 5, 2026
| tracer_advection = OC.WENO(order = 5) | ||
| horizontal_viscosity = OC.HorizontalScalarBiharmonicDiffusivity(ν = 1e11) | ||
| # Use Float32 for the vertical mixing parameters to avoid parameter memory limits | ||
| vertical_mixing = OC.CATKEVerticalDiffusivity(Float32) |
Comment on lines
143
to
150
| @info "Using simpler ocean setup; to be used for software testing only." | ||
| free_surface = OC.SplitExplicitFreeSurface(grid; substeps = 70) | ||
| momentum_advection = OC.VectorInvariant() | ||
| tracer_advection = OC.WENO(order = 5) | ||
| horizontal_viscosity = OC.HorizontalScalarBiharmonicDiffusivity(ν = 1e11) | ||
|
|
||
| # Create ocean simulation | ||
| free_surface = OC.SplitExplicitFreeSurface(grid; substeps = 70) | ||
| momentum_advection = OC.VectorInvariant() | ||
| tracer_advection = OC.WENO(order = 5) | ||
| horizontal_viscosity = OC.HorizontalScalarBiharmonicDiffusivity(ν = 1e11) | ||
| # Use Float32 for the vertical mixing parameters to avoid parameter memory limits | ||
| vertical_mixing = OC.CATKEVerticalDiffusivity(Float32) |
Contributor
There was a problem hiding this comment.
Suggested change
| @info "Using simpler ocean setup; to be used for software testing only." | |
| free_surface = OC.SplitExplicitFreeSurface(grid; substeps = 70) | |
| momentum_advection = OC.VectorInvariant() | |
| tracer_advection = OC.WENO(order = 5) | |
| horizontal_viscosity = OC.HorizontalScalarBiharmonicDiffusivity(ν = 1e11) | |
| # Create ocean simulation | |
| free_surface = OC.SplitExplicitFreeSurface(grid; substeps = 70) | |
| momentum_advection = OC.VectorInvariant() | |
| tracer_advection = OC.WENO(order = 5) | |
| horizontal_viscosity = OC.HorizontalScalarBiharmonicDiffusivity(ν = 1e11) | |
| # Use Float32 for the vertical mixing parameters to avoid parameter memory limits | |
| vertical_mixing = OC.CATKEVerticalDiffusivity(Float32) | |
| @info "Using simpler ocean setup; to be used for software testing only." | |
| free_surface = OC.SplitExplicitFreeSurface(grid; substeps = 70) | |
| momentum_advection = OC.VectorInvariant() | |
| tracer_advection = OC.WENO(order = 5) | |
| horizontal_viscosity = OC.HorizontalScalarBiharmonicDiffusivity(ν = 1e11) | |
| # Use Float32 for the vertical mixing parameters to avoid parameter memory limits | |
| vertical_mixing = OC.ConvectiveAdjustmentVerticalDiffusivity(background_κz = 1e-5, convective_κz = 0.1, background_νz = 1e-4, convective_νz = 0.1) |
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
New version of #1593 to use ConservativeRegridding with the TripolarGrid
Content
interpolate!callsconstruct_remappersto make the remapper object and allocate scratch space