feat(chpool): add healthcheck function #1088
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Neven Miculinic seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account. You have signed the CLA already but the status is still pending? Let us recheck it. |
nmiculinic
force-pushed
the
add_pool_healhchecking
branch
2 times, most recently
from
901e513 to
5833ddf
Compare
nmiculinic
changed the title
nmiculinic
force-pushed
the
add_pool_healhchecking
branch
from
5833ddf to
f6bed41
Compare
nmiculinic
changed the title
nmiculinic
force-pushed
the
add_pool_healhchecking
branch
2 times, most recently
from
e664181 to
c8638bb
Compare
nmiculinic
changed the title
nmiculinic
commented
Aug 28, 2025
| } | ||
| } | ||
|
|
||
| func (p *Pool) connIsHealthy(res *puddle.Resource[*connResource]) bool { |
There was a problem hiding this comment.
Happy to change this name to something better
nmiculinic
commented
Aug 28, 2025
| o.HealthCheckTimeout = DefaultHealthCheckTimeout | ||
| } | ||
| if o.ClientOptions.Logger == nil { | ||
| o.ClientOptions.Logger = zap.NewNop() |
There was a problem hiding this comment.
To prevent any nil-ptr exception later
nmiculinic
force-pushed
the
add_pool_healhchecking
branch
8 times, most recently
from
68dfbb1 to
50d4213
Compare
nmiculinic
force-pushed
the
add_pool_healhchecking
branch
from
50d4213 to
10694d0
Compare
|
@SpencerTorres @ernado mind having a look at this PR? |
|
@ernado perhaps you're more familiar with this pooling code? |
|
This code was contributed + I'm not using pools, so I'm familiar in same degree as you. |
|
@SpencerTorres @ernado any movement on this? What would make you happy to accept this PR |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Adding chpool healthchecking option.
Defaulting to
PingChecklist
Delete items not relevant to your PR: