Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: add marimo as an sql client #3593

Conversation

Light2Dark
Copy link
Contributor

@Light2Dark Light2Dark commented Apr 2, 2025

Summary

Hey! We're looking to add marimo as an SQL client integration, cc: @mneedham, @mscolnick

I can remove the sidebars.js change, it auto-formatted lol.

Checklist

Copy link

vercel bot commented Apr 2, 2025

@Light2Dark is attempting to deploy a commit to the ClickHouse Team on Vercel.

A member of the Team first needs to authorize it.

@CLAassistant
Copy link

CLAassistant commented Apr 2, 2025

CLA assistant check
All committers have signed the CLA.

@Light2Dark Light2Dark force-pushed the codespace-upgraded-fishstick-jj65jgpwxvqcqxxr branch from 99d4009 to 816039c Compare April 3, 2025 13:52
@Light2Dark Light2Dark marked this pull request as ready for review April 3, 2025 15:09
@Light2Dark Light2Dark requested review from a team as code owners April 3, 2025 15:09
@Light2Dark Light2Dark requested a review from kschlarman April 3, 2025 15:09
@mneedham
Copy link
Contributor

mneedham commented Apr 4, 2025

@Light2Dark you don't need the entry in vercel.json. The other entries are there because we used to have docs under /docs/en so the redirects are to avoid old links breaking. New docs go under /docs directly without the /en suffix, so no need to do a redirect.

Copy link

vercel bot commented Apr 4, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
clickhouse-docs ✅ Ready (Inspect) Visit Preview Apr 8, 2025 3:30pm
2 Skipped Deployments
Name Status Preview Comments Updated (UTC)
clickhouse-docs-ru ⬜️ Ignored (Inspect) Visit Preview Apr 8, 2025 3:30pm
clickhouse-docs-zh ⬜️ Ignored (Inspect) Visit Preview Apr 8, 2025 3:30pm

@Light2Dark
Copy link
Contributor Author

thanks, have made the change. formatting the sidebars.js is pretty hard, whenever I save, it formats everything.

@mneedham
Copy link
Contributor

mneedham commented Apr 4, 2025

This looks good to me

cc @Blargian to take a look too

@mneedham mneedham requested a review from Blargian April 4, 2025 14:29
@gingerwizard gingerwizard requested review from gingerwizard and removed request for kschlarman and Blargian April 6, 2025 17:07
@gingerwizard
Copy link
Contributor

@Light2Dark spellchecks need to be added or fixed

@gingerwizard gingerwizard self-requested a review April 8, 2025 10:50
Copy link
Contributor

@gingerwizard gingerwizard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fix spellings

@Light2Dark
Copy link
Contributor Author

Light2Dark commented Apr 8, 2025

I think it should be fixed, but I'm not sure how to re-check this locally.

@mneedham
Copy link
Contributor

mneedham commented Apr 8, 2025

@Light2Dark I think you've fixed everything

@Blargian Blargian merged commit 09029ba into ClickHouse:main Apr 9, 2025
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants