PMP enso #273
Draft
PMP enso #273
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lewisjared
reviewed
May 7, 2025
packages/climate-ref-pmp/src/climate_ref_pmp/diagnostics/enso.py
Outdated
Show resolved
Hide resolved
packages/climate-ref-pmp/src/climate_ref_pmp/diagnostics/enso.py
Outdated
Show resolved
Hide resolved
lee1043
commented
May 9, 2025
packages/climate-ref-pmp/src/climate_ref_pmp/requirements/environment.yml
Show resolved
Hide resolved
* origin/main: (38 commits) Add changelog Bump sample data to v0.5.1 Add regression test data chore: Remove old migration for metric_value columns test: Ensure that run is correctly mocked chore: Fix last test chore: Update cmec metric bundles revert: Roll back changing the data requirements for the modes of variability chore: revert some changes to avoid to many changes in this PR test: Add tests for remove_dimensions test: Fix tests fix: Add additional facets to variability modes fix: Add additional facets to annual_cycle chore: Remove excess dimensions and replace with selectors chore: Remove excess dimensions and replace with selectors test: Add ilamb integration test feat: Add a prepend routine chore: Check that metric bundles have the correct dimensions chore: Reorder functions docs: Changelog ...
lewisjared
reviewed
May 9, 2025
| DataRequirement( | ||
| source_type=SourceDatasetType.obs4MIPs, | ||
| filters=(FacetFilter(facets={"source_id": obs_sources, "variable_id": obs_variables}),), | ||
| group_by=("source_id", "variable_id"), |
There was a problem hiding this comment.
Suggested change
| group_by=("source_id", "variable_id"), | |
| group_by=("source_id",), |
I think that you are trying to get two obs groups one per source id rather than multiple groups per source id
There was a problem hiding this comment.
@lewisjared There are some metrics that takes two different variables from two different sources, e.g., pr from GPCP and ts from HadSST. Can I leave group_by empty (group_by = ()) for such cases?
lewisjared
reviewed
May 9, 2025
packages/climate-ref-pmp/src/climate_ref_pmp/diagnostics/enso.py
Outdated
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Checklist
Please confirm that this pull request has done the following:
changelog/