Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Resource Filter Settings in URL #361

Merged
merged 13 commits into from
Dec 28, 2023
Merged

Conversation

dmlb
Copy link
Contributor

@dmlb dmlb commented Nov 10, 2023

Describe your changes

Query Params for search, tags, mode

  • onMount for initial navigation
  • $ for catching changes between URL and components
  • replaceQuery HistoryAPI update to URL

Related issue number/link

#360

@dmlb dmlb requested a review from VeckoTheGecko November 10, 2023 00:40
Makes the deletion of the params the default, treating values as the source of truth (this has the effect of also cleaning up a dirty url .../resources?tags=broken-tag)
Copy link
Collaborator

@VeckoTheGecko VeckoTheGecko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this feature. Questions about emojis in URL, and code quality/transparency items before shipping.

Happy to help with dev if you want me to push changes.

src/lib/components/FilterForm.svelte Outdated Show resolved Hide resolved
src/lib/components/FilterForm.svelte Outdated Show resolved Hide resolved
src/lib/components/FilterForm.svelte Outdated Show resolved Hide resolved
src/routes/resources/+page.svelte Outdated Show resolved Hide resolved
@dmlb dmlb requested a review from VeckoTheGecko December 19, 2023 18:20
Copy link
Collaborator

@VeckoTheGecko VeckoTheGecko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM now! Happy to merge

@VeckoTheGecko VeckoTheGecko merged commit d29f5ac into ClimateTown:main Dec 28, 2023
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants