Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix-pubmlst-query-insert #203

Merged
merged 5 commits into from
Mar 26, 2025
Merged

Fix-pubmlst-query-insert #203

merged 5 commits into from
Mar 26, 2025

Conversation

karlnyr
Copy link
Contributor

@karlnyr karlnyr commented Mar 20, 2025

Description

This PR tries to adress the issue that when we download databases and try to update existing ones we have the clonal complex and species column. Two columns that are not used in the analysis.

Code Formatting Improvements:

Minor Logic Adjustments:

  • microSALT/store/models.py: Limited the number of elements considered in the header to the first 8 elements to avoid unnecessary processing. [1] [2]

  • microSALT/utils/referencer.py: Added logic to only write the first 8 columns of the profiles CSV to avoid adding unnecessary information such as "clonal_complex" and "species".

Primary function of PR

  • Hotfix
  • Patch
  • Minor functionality improvement
  • New type of analysis
  • Backward-breaking functionality improvement
  • This change requires internal documents to be updated
  • This change requires another repository to be updated

Testing

If the update is a hotfix, it is sufficient to rely on the development testing along with the Travis self-test automatically applied to the PR.

Test routine to verify the stability of the PR:

  • bash /home/proj/production/servers/resources/hasta.scilifelab.se/install-microsalt-stage.sh BRANCHNAME
  • us
  • conda activate S_microSALT
  • (SITUATIONAL) export MICROSALT_CONFIG=/home/proj/dropbox/microSALT.json
  • Select a relevant subset of the following:
  • microSALT analyse project MIC3109
  • microSALT analyse project MIC4107
  • microSALT analyse project MIC4109
  • microSALT analyse project ACC5551

Verify that the results for projects MIC3109, MIC4107, MIC4109 & ACC5551 are consistent with the results attached to AMSystem doc 1490, Microbial_WGS.xlsx

Test results

These are the results of the tests, and necessary conclusions, that prove the stability of the PR.

Sign-offs

@karlnyr karlnyr requested a review from a team as a code owner March 20, 2025 15:07
@karlnyr
Copy link
Contributor Author

karlnyr commented Mar 26, 2025

Tested to run and generate a report for MIC4109:

New report:

image

Old report:

image

Same ST types were yielded. There is a difference in resistances, due to database updates. However, we are generating the same set of resistance groups.

@karlnyr karlnyr merged commit 7ab07eb into rc4.2.0 Mar 26, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant