Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR tries to adress the issue that when we download databases and try to update existing ones we have the clonal complex and species column. Two columns that are not used in the analysis.
Code Formatting Improvements:
microSALT/store/models.py
: Simplified the formatting of error messages and file handling to improve readability. [1] [2]Minor Logic Adjustments:
microSALT/store/models.py
: Limited the number of elements considered in the header to the first 8 elements to avoid unnecessary processing. [1] [2]microSALT/utils/referencer.py
: Added logic to only write the first 8 columns of the profiles CSV to avoid adding unnecessary information such as "clonal_complex" and "species".Primary function of PR
Testing
If the update is a hotfix, it is sufficient to rely on the development testing along with the Travis self-test automatically applied to the PR.
Test routine to verify the stability of the PR:
bash /home/proj/production/servers/resources/hasta.scilifelab.se/install-microsalt-stage.sh BRANCHNAME
us
conda activate S_microSALT
export MICROSALT_CONFIG=/home/proj/dropbox/microSALT.json
microSALT analyse project MIC3109
microSALT analyse project MIC4107
microSALT analyse project MIC4109
microSALT analyse project ACC5551
Verify that the results for projects MIC3109, MIC4107, MIC4109 & ACC5551 are consistent with the results attached to AMSystem doc 1490, Microbial_WGS.xlsx
Test results
These are the results of the tests, and necessary conclusions, that prove the stability of the PR.
Sign-offs