[feat/#87] 좋아요한 기록 조회 api 구현 #114
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
juuuuone
requested review from
2ghrms,
Ssamssamukja,
dev2yup and
yongjun0511
as code owners
|
yongjun0511
reviewed
Nov 23, 2025
| @GetMapping("/histories") | ||
| @Operation(summary = "좋아요한 기록 조회", description = "사용자가 좋아요한 기록을 조회합니다.") | ||
| public BaseResponse<SliceResponse<LikedHistoriesResponse.LikedHistoryPreview>> | ||
| getLikedHistories(@PageableDefault(size = 10) Pageable pageable) { |
Collaborator
There was a problem hiding this comment.
저희 프로젝트는 통일된 커서 기반 페이징을 사용하고 있어서 다른 Paging이 쓰이고 있는 부분들을 참고하시면 좋을 것 같아요.
ex) 기록 목록 조회, 댓글 목록 조회 , 알림 목록 조회 , 옷 목록 조회 등등...
현재의 pageable 입력값은 offset 기반 페이징에 더 적합한 것 같아요.
- 이게 Swagger에서 어떻게 보일지..? 잘 모르겠는데 저기 있는 많은 변수들을 선택적으로 넣을 수 있는건지..?
그래서 기존 처럼 DTO 프로젝션 + 커서 페이징 참고해서 가져다 쓰시면 될 것 같습니다!
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📌 연관 이슈
🌱 PR 요약
좋아요한 기록과 기록의 첫번째 사진을 조회하는 api입니다.
🛠 작업 내용
📸 스크린샷
❗️리뷰어들께