feat : 좋아요 api 구현 #174
Merged
feat : 좋아요 api 구현 #174
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
juuuuone
requested review from
2ghrms,
Ssamssamukja,
dev2yup and
yongjun0511
as code owners
Closed
dev2yup
approved these changes
Jan 1, 2026
| () -> | ||
| new BaseCustomException( | ||
| HistoryErrorCode | ||
| .HISTORY_NOT_FOUND)); // 💡 예외 통일성 유지 |
|
|
||
| private boolean isBlockedByOrBlocking(Long fromId, Long toId) { | ||
| return blockRepository.existsByBlockerIdAndBlockedId(fromId, toId) | ||
| || blockRepository.existsByBlockerIdAndBlockedId(toId, fromId); |
Collaborator
There was a problem hiding this comment.
여기 부분 db 접근이 두번 발생하는데
or 쿼리로 한번에 해결하는 방법도 괜찮을 것 같아요
| HistoryErrorCode | ||
| .HISTORY_NOT_FOUND)); // 💡 예외 통일성 유지 | ||
|
|
||
| final Member historyOwner = history.getMember(); |
Collaborator
There was a problem hiding this comment.
여기 lazy loading 돼있으니까 n+1문제 땜에
history랑 member랑 fetch join해서 한번에 갖고 오는게 좋겠습니다!!
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📌 연관 이슈
🌱 PR 요약
🛠 작업 내용
📸 스크린샷
❗️리뷰어들께