imageserver: add directory dashboard and ability to list images in a directory#256
Open
narendraReddy45 wants to merge 4 commits intoCloud-Foundations:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description & Motivation
This PR implements the below:
listDirectoriesapilistImagesapi now accepts query parameterdirectoryNameand returns images matching that directoryName prefixApproach
The image database currently has a hashmap of image names and their respective metadata. To get all images matching a certain prefix, we could do a linear search on each element and return a list of images.
But this approach may not be scalable, as
listImageswould loop overlen(images)for every call, sort the results, and return.Optimized the prefix search by creating an index on image names. The index is implemented using a golang slice, maintaining a sorted order of elements and doing a binary search every time a search is needed.
As our dataset grows, we can eventually shift to a trie-based index for better performance. As trie improves insertion and deletion to O(L) where L is the length of the imagename.
Given our dataset N ( e.g.636: from http://imageserver.dev.purestorage.com:6971/metrics/image-count ) is smaller , the performance is comparable and slices are contiguous
Fixes #248
Type of Change
How Has This Been Tested?
Testing Approach
Checklist: