updates april 20206#293
Merged
Merged
Conversation
rgooch
reviewed
Apr 2, 2026
| rpTopOrigins := rpOrigins // FIXME: we actually have to compute this | ||
| validError := parsedResponse.Verify(session.Challenge, rpID, rpOrigins, rpTopOrigins, protocol.TopOriginAutoVerificationMode, appID, shouldVerifyUser, loginCredential.PublicKey) | ||
| verifyUserPresence := true | ||
| validError := parsedResponse.Verify(session.Challenge, rpID, rpOrigins, rpTopOrigins, protocol.TopOriginAutoVerificationMode, appID, shouldVerifyUser, verifyUserPresence, loginCredential.PublicKey) |
Member
There was a problem hiding this comment.
Did the external webauthn package make an incompatible API change?
Contributor
Author
There was a problem hiding this comment.
yes it did. I do have to actually test on a keymaster with a real hostname if the behaviour of this new param: verifyUserPresence is what I expect. We are using a "less traveled" path as we need to use some of the internal apis for backwards compatility with u2f registered tokens. We may start thnking on when we will drop that and go to only webauthn flows.
I will not land until I have actually tested this.
Contributor
Author
There was a problem hiding this comment.
Just tested works with new path (localhost)l
rgooch
approved these changes
Apr 8, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.