Elide nonce allocation in encrypt path#36
Merged
arashpayan merged 4 commits intomainfrom Mar 10, 2026
Merged
Conversation
Exercises the send/recv path through conn using net.Pipe and a fake server, measuring throughput at different payload sizes for plain and encrypted sessions.
Generate the nonce directly into the transform header buffer instead of allocating a separate slice and copying it. This removes one allocation from the hot path per encrypted send/receive. Before: BenchmarkRoundTrip/Encrypted/64KB-10 38607 31706 ns/op 2067.02 MB/s 164634 B/op 9 allocs/op After: BenchmarkRoundTrip/Encrypted/64KB-10 39374 31195 ns/op 2100.83 MB/s 164614 B/op 8 allocs/op
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Generate the nonce directly into the transform header buffer instead of
allocating a separate slice and copying it. This removes one allocation
from the hot path per encrypted send/receive.
Before:
BenchmarkRoundTrip/Encrypted/64KB-10 38607 31706 ns/op 2067.02 MB/s 164634 B/op 9 allocs/op
After:
BenchmarkRoundTrip/Encrypted/64KB-10 39374 31195 ns/op 2100.83 MB/s 164614 B/op 8 allocs/op