Add compound requests and ReaddirPlus for batched security descriptor queries#42
Merged
Add compound requests and ReaddirPlus for batched security descriptor queries#42
Conversation
arashpayan
requested changes
Mar 15, 2026
Collaborator
|
It's an impressive but complex PR, so it took me awhile to get through reviewing it in detail. |
… queries Introduces SMB2 compound request support (CREATE+QUERY_INFO+CLOSE triplets batched into single round-trips) and exposes it via File.ReaddirPlus and Share.ReadDirPlus, which enrich directory listings with security descriptors while respecting credit limits through automatic sub-batching.
The previous calculation with uint16s would overflow at 21845 directory entries. Use ints instead and clamp later.
Discard error on close
…scriptor was loaded
arashpayan
approved these changes
Mar 16, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Introduces SMB2 compound request support (CREATE+QUERY_INFO+CLOSE triplets batched into single round-trips) and exposes it via File.ReaddirPlus and Share.ReadDirPlus, which enrich directory listings with security descriptors while respecting credit limits through automatic sub-batching.
Tested with a container running samba and running the integration tests: