Replace conn.session with atomic.Pointer#44
Merged
arashpayan merged 2 commits intomainfrom Mar 17, 2026
Merged
Conversation
The session variable in conn was accessed after _useSession was polled via an atomic.Load(), but this obscured the safety of loads and stores of conn.session. This change introcuces an atomic.Pointer for clarity, and also guarantees that if conn.session is accessed without first verifying useSession that conn will not be accessed unsafely. This change provides some code clarity, but should not affect the correctness of the code.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The session variable in conn was accessed after
_useSessionwaspolled via an
atomic.Load(), but this obscured the safety ofloads and stores of
conn.session.This change introduces an
atomic.Pointerfor clarity, and alsoguarantees that if
conn.sessionis accessed without first verifyinguseSession that conn will not be accessed unsafely.
This change provides some code clarity, but should not affect the
correctness of the code -- it was correct before.