Fix: sbd: Avoid negative value for the property 'stonith-watchdog-timeout' (bsc#1246622) #1865
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…eout' (bsc#1246622) Set its default value to 2*SBD_WATCHDOG_TIMEOUT
liangxin1300
force-pushed
the
20250717_avoid_nagative_value_for_stonith_watchdog_timeout
branch
from
ca6db07 to
2dc86dd
Compare
gao-yan
approved these changes
Jul 17, 2025
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files
Flags with carried forward coverage won't be shown. Click here to find out more.
☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
nicholasyang2022
approved these changes
Jul 18, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Previously, when configuring diskless SBD with crmsh bootstrap, the option
stonith-watchdog-timeoutwas set to -1 to prompt Pacemaker to automatically calculate the appropriate value.However, Pacemaker now raises a warning when a negative value is used for timeout or duration options such as
stonith-watchdog-timeout:Changes
Set the default value of
stonith-watchdog-timeoutto 2*SBD_WATCHDOG_TIMEOUT. The value of SBD_WATCHDOG_TIMEOUT is stored in /etc/sysconfig/sbd and can be kept consistent across all nodes using crmsh.