Low: libcrmservices: Don't leak msg if systemd_proxy is NULL.

ClusterLabs · Feb 5, 2025 · 51a93e7 · 51a93e7
1 parent 96e9bff
commit 51a93e7
Showing 1 changed file with 3 additions and 1 deletion.
diff --git a/lib/services/systemd.c b/lib/services/systemd.c
@@ -104,13 +104,15 @@ systemd_send_recv(DBusMessage *msg, DBusError *error, int timeout)
 static DBusMessage *
 systemd_call_simple_method(const char *method)
 {
-    DBusMessage *msg = systemd_new_method(method);
+    DBusMessage *msg = NULL;
     DBusMessage *reply = NULL;
     DBusError error;
 
     /* Don't call systemd_init() here, because that calls this */
     CRM_CHECK(systemd_proxy, return NULL);
 
+    msg = systemd_new_method(method);
+
     if (msg == NULL) {
         crm_err("Could not create message to send %s to systemd", method);
         return NULL;