Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Finish updating CTS to pass pylint and pyflake #3820

Open
wants to merge 22 commits into
base: main
Choose a base branch
from
+287 −253
Open

Finish updating CTS to pass pylint and pyflake #3820

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
22 commits
Select commit Hold shift + click to select a range
9e68c09
Refactor: cts: Add the usual pylint import and name pragmas.
clumens Jan 31, 2025
52c2e5e
Refactor: cts: Fix the last few pyflake problems in cts-regression.
clumens Jan 31, 2025
269bb7d
Refactor: cts: Give an explicit encoding to uses of io.open.
clumens Jan 31, 2025
8eff942
Refactor: cts: Don't inherit from object.
clumens Jan 31, 2025
300f32a
Refactor: cts: Condense test descriptions onto single lines.
clumens Jan 31, 2025
478bcab
Refactor: cts: Use f-strings in cts-scheduler.
clumens Jan 31, 2025
005aa14
Refactor: python: Use += in cts-scheduler for increment.
clumens Jan 31, 2025
c1ad55d
Refactor: python: Don't explicitly compare against an empty list.
clumens Jan 31, 2025
8b3fb1e
Refactor: cts: Disable pylint warnings we're not going to address.
clumens Jan 31, 2025
51fd5da
Refactor: cts: Unindent some code where possible.
clumens Jan 31, 2025
319d6d3
Refactor: cts: Fix whitespace around lists and operators.
clumens Jan 31, 2025
6148e7b
Refactor: cts: Get rid of the DESC variable.
clumens Jan 31, 2025
5194449
Refactor: python: Improve whitespace throughout cts-scheduler.
clumens Jan 31, 2025
b94af94
Refactor: cts: Add a function to check if a file is missing or empty.
clumens Jan 31, 2025
1fb2049
Refactor: cts: Improve docstrings in cts-scheduler.
clumens Jan 31, 2025
113cfad
Refactor: cts: Disable the too-many-locals warning in cts-scheduler.
clumens Jan 31, 2025
4aec544
Refactor: python: Disable the similar code warning from pylintrc.
clumens Jan 31, 2025
8343638
Build: cts: Add cts-cli to the python_files list.
clumens Jan 31, 2025
de708fb
Refactor: cts: Fix a pyflake whitespace problem in cts-cli.
clumens Jan 31, 2025
de1200a
Refactor: cts: Replace {shadow} strings in cts-cli where possible.
clumens Jan 31, 2025
7032046
Refactor: cts: Use {cts_cli_data} as an f-string where possible.
clumens Jan 31, 2025
4e64a39
Refactor: cts: Remove unnecessary whitespace from the end of commands.
clumens Feb 17, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion cts/Makefile.am
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
#
# Copyright 2001-2024 the Pacemaker project contributors
# Copyright 2001-2025 the Pacemaker project contributors
#
# The version control history for this file may have further details.
#
Expand Down Expand Up @@ -67,7 +67,10 @@ cts-support-uninstall:
# Everything listed here is a python script, typically generated from a .in file
# (though that is not a requirement). We want to run pylint on all of these
# things after they've been built.
# FIXME: When cts-schemas is converted to python, this can be removed because
# it will duplicate test_SCRIPTS above.
python_files = cts-attrd \
cts-cli \
cts-exec \
cts-fencing \
cts-lab \
Expand Down
Loading