Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Logging improvements #3825

Open
wants to merge 7 commits into
base: main
Choose a base branch
from
Open

Logging improvements #3825

wants to merge 7 commits into from

Conversation

clumens
Copy link
Contributor

@clumens clumens commented Feb 11, 2025

This is exactly the same as #3803 except for one very minor bug fix that enables it to pass ctslab. I currently have a long run going to check for any additional problems. I think we can go ahead and get this one through proper review in the meantime.

cib_file_read_and_verify() can return other errors than were being
caught.
Previously, terminate_cib() would log an info message, and most callers
would log additional, partially redundant messages. Now, log at the
callers (who have better context), and don't log in terminate_cib().

Also, improve the wording of the messages, and drop the no longer
necessary caller argument to terminate_cib().
Avoid logging XML (especially at notice level), instead picking out the
interesting attributes. Previously, the message was at debug level
(instead of notice) if the DC's CIB was used, but I think it makes sense
to always log at notice for troubleshooting purposes.
Previously, the controller could create a dot file of its FSA
transitions -- as trace log messages. Someone would have to copy and
paste the relevant portion of each trace log into a file to use it.
Stop the insanity now.
... and de-functionize crmd_init().

crmd_fast_exit() -> crm_exit() already logs an exit message, so we don't
need a separate one here.
Don't log that we're requesting execution if we're not, and make the
go/no-go logs more consistent. Also, drop a redundant log for local
execution in execute_rsc_action().
@clumens
Copy link
Contributor Author

clumens commented Feb 18, 2025

@waltdisgrace This might also be another good one for you to review.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants