Build: Fix coverage targets. #3830
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* COVERAGE_DIR should be an absolute path so it doesn't get accidentally created outside of the source/build tree. * Use long command line arguments to everything to make it a little more clear what these commands do. We so rarely use any of these tools that no one remembers the short versions. * Ignore unused excludes. At some point, an unused exclude became an error which stops the build process. Ignore those errors instead of trying to figure out what is and isn't used. * Restrict code coverage to the lib/ directory in the main target. Previously, we were scanning everything and then going through and removing certain directories. Instead, let's just scan the one thing we do care about. This loses coverage checking of include/, but I'm okay with that. * Add && before the genhtml commands. This was previously broken - the line continuation made it part of the preceeding lcov command.
|
@waltdisgrace Here's a pretty simple build process fix if you could review it. Thanks. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
COVERAGE_DIR should be an absolute path so it doesn't get accidentally created outside of the source/build tree.
Use long command line arguments to everything to make it a little more clear what these commands do. We so rarely use any of these tools that no one remembers the short versions.
Ignore unused excludes. At some point, an unused exclude became an error which stops the build process. Ignore those errors instead of trying to figure out what is and isn't used.
Restrict code coverage to the lib/ directory in the main target. Previously, we were scanning everything and then going through and removing certain directories. Instead, let's just scan the one thing we do care about. This loses coverage checking of include/, but I'm okay with that.
Add && before the genhtml commands. This was previously broken - the line continuation made it part of the preceeding lcov command.