Overhaul crm_resource

cts/cli/regression.crm_resource.exp

@@ -2,7 +2,6 @@
 crm_resource: non-option ARGV-elements:
 [1 of 2] foo
 [2 of 2] bar
-
 =#=#=#= End test: crm_resource run with extra arguments - Incorrect usage (64) =#=#=#=
 * Passed: crm_resource          - crm_resource run with extra arguments
 =#=#=#= Begin test: List all available resource options (invalid type) =#=#=#=

cts/cts-cli.in

@@ -1804,7 +1804,7 @@ class CrmResourceRegressionTest(RegressionTest):
                             "crm_resource --locate -r promotable-rsc:1 {fmt}",
                             [Test, ValidatingTest]),
             Test("Try to move an instance of a cloned resource",
-                 "crm_resource -r promotable-rsc:0 --move --node node1",
+                 "crm_resource -r promotable-rsc:0 --move --node cluster01",
                  expected_rc=ExitStatus.INVALID_PARAM),
         ]
 

lib/services/services.c

@@ -250,6 +250,7 @@ copy_action_arguments(svc_action_t *op, uint32_t ra_caps, const char *name,
     return pcmk_rc_ok;
 }
 
+// Takes ownership of params
 svc_action_t *
 services__create_resource_action(const char *name, const char *standard,
                         const char *provider, const char *agent,