Fix promotable follows promotable with attribute #3975
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wenningerk
force-pushed
the
fix_promotable_follows_promotable_with_attribute
branch
from
40ca725 to
6ce4fed
Compare
Contributor
Author
|
oops adding the test to the list ended up in the fix commit - have to move that to the test commit |
clumens
reviewed
Nov 4, 2025
cts/cts-scheduler.in
Outdated
| SchedulerTest("no_quorum_demote", "Promotable demotion and primitive stop with no-quorum-policy=\"demote\""), | ||
| SchedulerTest("no-promote-on-unrunnable-guest", "Don't select bundle instance for promotion when container can't run"), | ||
| SchedulerTest("leftover-pending-monitor", "Prevent a leftover pending monitor from causing unexpected stop of other instances"), | ||
| SchedulerTest("promotable-colocation-with-node-attribute", "Promote dependend clone on nodes belonging to a site that has a primary clone promoted"), |
Contributor
There was a problem hiding this comment.
Move this to the second patch, and I think you meant "Promote dependent" instead of "Promote dependend".
clumens
requested changes
Nov 4, 2025
Contributor
clumens
left a comment
clumens
left a comment
There was a problem hiding this comment.
I just had one little comment. I think this is okay, though this is very much not my area of expertise. I ran it through regression and cts-lab tests without failure.
Contributor
|
@wenningerk This fixes RHEL-120932 and RHEL-81951, right? Could you add that to the commit message as well? |
Add testcase. Previous fix attribute based colocation didn't adhere the attribute with promoted state with promoted state.
Previously attribute based colocation didn't adhere the attribute with promoted state with promoted state.
wenningerk
force-pushed
the
fix_promotable_follows_promotable_with_attribute
branch
from
6ce4fed to
b5c2ab8
Compare
clumens
approved these changes
Nov 7, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This attempts to fix https://projects.clusterlabs.org/T975
Unexpectedly collocation with promoted status works quite differently than collocation with a primitive.
Maybe the cleaner approach here would be to make that more alike.
Alternatively passing a node-attribute down to pcmk__instance_matches at least does the job.