Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Review2 #5

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Review2 #5

wants to merge 2 commits into from

Conversation

KoenDG
Copy link

@KoenDG KoenDG commented Jun 6, 2016

Mostly recommended performance improvements and addressing possible memory issues, all according to Intellij's static code analysis.

Please check the branch out and try it before merging.

* Copied from the Intellij code analysis:
* A static inner class does not keep an implicit reference to its enclosing instance.
* This prevents a common cause of memory leaks and uses less memory per instance of the class.
*/
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Apparently a potential source of memory leaks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant