-
Notifications
You must be signed in to change notification settings - Fork 59
Added ci workflow #40
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
✅ Deploy Preview for paisable canceled.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi, thanks for adding the CI workflow! This is a great addition. I have a few suggestions:
- Please move the secrets (JWT_SECRET, etc.) to the repository's GitHub Secrets and reference them with ${{ secrets.SECRET_NAME }}. This is a crucial security practice, even for placeholders.
- The main purpose of CI is to run tests. Could you please add an
npm test
step for both the frontend and backend? This will act as a safety net for all future changes. - Once the test commands are in place, the current logic using npm run dev and sleep can be removed.
Sure i will fix it by today. |
Hey @KumarAyush204, thank you for opening this PR. I am not very familiar with CI workflows, but I see that you have commented out the mongo host configs, won't they cause a problem? Also, you've commented out the |
@archa8 Sorry I was working on the forked repo and was testing it. I didnt knew that changes are getting reflected here directly. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Un comment your services workflow. Rest All Good 🎉
|
||
echo "Server failed to start. Printing logs:" | ||
cat server.log | ||
kill $server_pid |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Have you test in case of DB not connected?
I think you need to update the db not to be take exit in case of CI workflow. Right?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There are some problems related to db test cases right now. I'm trying to figure it out. Once fixed i will mention you.
Description
This PR introduces a GitHub Actions workflow (.github/workflows/ci.yml) that ensures the project remains in a stable and working state. The workflow runs on every push and pull request targeting the main branch.
Related Issue
Fixes #17
Motivation and Context
🤔 Motivation
Types of Changes
How Has This Been Tested?
The CI workflow has been successfully tested in my forked repository. All jobs (backend and frontend setup, server start, and validation checks) executed as expected, and the workflow correctly reported status (✅ passed) based on current status of application health and can ❌ fail if something goes wrong.
@archa8 You can test the pipeline during merge.
Screenshots (if applicable):
Checklist