Skip to content

hamburger nav bar for participant#208

Merged
burtonjong merged 8 commits into
mainfrom
HMT-148-Participant-nav-same-as-judge
Jun 15, 2025
Merged

hamburger nav bar for participant#208
burtonjong merged 8 commits into
mainfrom
HMT-148-Participant-nav-same-as-judge

Conversation

@anthonyych4n
Copy link
Copy Markdown
Contributor

No description provided.

Copy link
Copy Markdown
Contributor

@burtonjong burtonjong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This needs to be on all pages, not just the participant one. Like if im on / i need to be able to see the hamburger thing as well

I am just going to extend this ticket as well, you need to make it role based. Based on role you have to render a specific navbar for each role based on what they are able to access

@burtonjong
Copy link
Copy Markdown
Contributor

For example, normal participants shouldnt see any links leading to the admin dashboard or anything because that wouldnt make sense, nor judges

Copy link
Copy Markdown
Contributor Author

@anthonyych4n anthonyych4n left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok i changed, lmk if you want me to do anything else

Copy link
Copy Markdown
Contributor

@burtonjong burtonjong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

image

what happened here lol

also delete the chatgpt comments bro LOL

Comment thread src/components/Dashboard/GoToFoodTicket.tsx
Comment thread src/components/Dashboard/GoToFoodTicket.tsx
Comment thread src/app/participant/important-info/page.tsx Outdated
Comment thread src/app/participant/judging-info/page.tsx Outdated
Comment thread src/components/Dashboard/UserBasedNav.tsx
…hows up in every page based on user. deleted chat gpt comments
Copy link
Copy Markdown
Contributor

@fisayoadabs fisayoadabs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall it looks good do you think we should have the purple awesomer font colors on the border when hovering? Or is that too much?

Copy link
Copy Markdown
Contributor

@burtonjong burtonjong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When opening and closing the nav can we have the X and hamburger icon appear in the same place so users dont have to move their mouse

also when clicking on a link and the navbar goes back into the left, it looks like the hamburger icon is "intersecting" with the nav if that makes sense

and then can we wait for the load before even showing the join hackathon? so like a loading state to see if the user.username has even loaded if that makes sense before rendering anything

@burtonjong
Copy link
Copy Markdown
Contributor

otherwise looks good - and maybe address fizzys comment. it would be nice to have some kind of indicator that you are hoving the hamburger icon as well :)

Copy link
Copy Markdown
Contributor

@burtonjong burtonjong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

otherwise looks good

Comment thread src/components/Header.tsx Outdated
)}
</div> */}
<div className="flex w-48">
{typeof user === "undefined" ? (
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
{typeof user === "undefined" ? (
{user.id === "" ? (

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

image

the way that the user is originally assigned a role is like this, not undefined as per written in code in the user context:

image

@burtonjong burtonjong merged commit 9103f78 into main Jun 15, 2025
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants