Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes #63 and miscellaneous bugs. #66

Merged
merged 4 commits into from
Jan 3, 2015
Merged

Fixes #63 and miscellaneous bugs. #66

merged 4 commits into from
Jan 3, 2015

Conversation

JoshVarty
Copy link
Contributor

This fixes #63 as well as some undocumented bugs with parameters and local variables:

  • Local variable's fully qualified names were being set to their simple name. This meant that using variables both named data in different functions would cause one definition to incorrectly link to the other.
  • Parameters were linking to the method itself instead of the parameter inside of the method.
  • Search was returning local variables and parameters.

In order to differentiate between different local variables, I append a delimeter (::) and the simple name of the variable to the function or property in which they are contained.

Consider the following:

namespace MyNamespace
{
    class MyClass 
    {
        void MyMethod() { int myVariable = 4; }
    }
}

The fully qualified name of myVariable is now MyNamespace.MyClass.MyMethod::myVariable. I believe this should work for C# but I'm less familiar with naming rules in VB .Net.

I'll be using a similar approach (but a different delimiter) for #64.

This allows us to avoid searching for certain tokens such as locals and
function parameters.
This applies to #63 but also fixes various issues with local variables
that hadn't been noticed yet. We desperately need tests.
AmadeusW added a commit that referenced this pull request Jan 3, 2015
Fixes #63 and miscellaneous bugs.
@AmadeusW AmadeusW merged commit 80942ef into CodeConnect:master Jan 3, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Constructor aren't handled correctly.
2 participants