Open
Conversation
jamesonji
suggested changes
Nov 25, 2016
Contributor
jamesonji
left a comment
jamesonji
left a comment
There was a problem hiding this comment.
Need to remove spaces and comments. Improve test for 'save session id of current user'
| it 'saves session id of current user' do | ||
| # u = create(:user) | ||
| # expect(session[:user_id]).to eq(u.id) | ||
|
|
Contributor
There was a problem hiding this comment.
Remove comment and space below it.
Probably better to set session[:user_id] to nil first and then do the comparison. I like the way you did in the comment though.
| it 'saves a record to the database' do | ||
| count_before = User.count | ||
| valid_user | ||
|
|
Contributor
There was a problem hiding this comment.
Remove space, lesson learned from Steve
| it 'does not save a record to the database' do | ||
| count_before = User.count | ||
| invalid_user | ||
|
|
Contributor
There was a problem hiding this comment.
Remove this space too >. <
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
testing for the user controller actions are implemented.
@jamesonji please, review this.