Skip to content

Conversation

thecoolwinter
Copy link
Collaborator

@thecoolwinter thecoolwinter commented Sep 10, 2025

Description

Updates the tab bar for a new glass/capsule based design for macOS 26. This change is not retroactive and only affects CodeEdit running on macOS 26.

The new design does two things primarily:

  • Tabs are now embedded in a glass container capsule.
  • Tabs are themselves glass, and are also capsule shaped.

This changes makes the tab bar look at home on the new bubbly, liquid design of Tahoe. Tabs are still draggable, selectable, etc, they're just a little more prominently in their own container.

We are not going to change our tab behavior to match Xcode, and this PR reflects that. Tabs still act the same way as they have in Sequoia, this is purely a design change.

Tab content also still appears to slide underneath the toolbar. However due to the greater opacity of the toolbar, the split view was updated to be aware of the safe area and only draw where necessary. Alternatives were considered, such as trying to make the editor itself bleed over into the safe area, but due to SwiftUI limitations for escaping safe areas this was the best option I could find.

Related Issues

Checklist

  • I read and understood the contributing guide as well as the code of conduct
  • The issues this PR addresses are related to each other
  • My changes generate no new warnings
  • My code builds and runs on my machine
  • My changes are all related to the related issue above
  • I documented my code

Screenshots

Split tab panes with new tab bar design.

Screenshot 2025-09-10 at 11 14 14 AM

Some tab styles (selected, hovered, scrolled under container).
image
image
image

commit 6218d89
Author: Khan Winter <[email protected]>
Date:   Thu Sep 4 10:09:23 2025 -0500

    Revert Project File Changes

commit 46f4e36
Author: Khan Winter <[email protected]>
Date:   Tue Sep 2 14:41:03 2025 -0500

    Toolbar Opacity

commit 79b49b3
Author: Khan Winter <[email protected]>
Date:   Fri Aug 29 16:45:12 2025 -0500

    Correct Arrow Edge in Scheme Popover

commit c2e7e70
Author: Khan Winter <[email protected]>
Date:   Fri Aug 29 16:37:39 2025 -0500

    fix:lint

commit 9408577
Author: Khan Winter <[email protected]>
Date:   Fri Aug 29 16:36:26 2025 -0500

    Remove Unified Style (and fix the rabbit hole of bugs that caused)

commit 22b5b93
Author: Khan Winter <[email protected]>
Date:   Fri Aug 29 12:38:53 2025 -0500

    Adjust Task Notification View

commit c7c30af
Author: Khan Winter <[email protected]>
Date:   Fri Aug 29 11:58:05 2025 -0500

    Update Popover Style

commit bc152a0
Author: Khan Winter <[email protected]>
Date:   Fri Aug 29 11:37:46 2025 -0500

    Use new WelcomeWindow Release

commit 45aa64c
Author: Khan Winter <[email protected]>
Date:   Fri Aug 29 11:32:43 2025 -0500

    Finish Activity Viewer Pills

commit 7e50ff9
Author: Khan Winter <[email protected]>
Date:   Thu Aug 28 16:22:32 2025 -0500

    Adjust Branch Picker and Scheme Dropdown

commit f39c497
Author: Khan Winter <[email protected]>
Date:   Thu Aug 28 16:22:17 2025 -0500

    Fix Warning

commit a4c879f
Author: Khan Winter <[email protected]>
Date:   Thu Aug 28 16:22:11 2025 -0500

    Add Start/Stop Task Toolbar Group

commit 9d74f8a
Author: Khan Winter <[email protected]>
Date:   Thu Aug 28 16:21:33 2025 -0500

    Fix Concurrency Issues

commit 1d590a9
Author: Khan Winter <[email protected]>
Date:   Thu Aug 28 16:20:58 2025 -0500

    Update Project, Use local WelcomeWindow for now
@thecoolwinter thecoolwinter added the macOS Tahoe Issues for macOS Tahoe label Sep 10, 2025
@jacob-carlborg
Copy link

On the big screenshot, on the tab with the title CodeEditApp.swift, I think Swift icon is very close to the left edge of the tab. Perhaps some more space between the icon and the left edge (padding or whatever it's called)?

@thecoolwinter
Copy link
Collaborator Author

On the big screenshot, on the tab with the title CodeEditApp.swift, I think Swift icon is very close to the left edge of the tab. Perhaps some more space between the icon and the left edge (padding or whatever it's called)?

Sorry it's not obvious from the screenshot but I have that tab bar scrolled slightly off to the right to show the edge shadows on both sides. The other two tab bars are better examples of the spacing.

@thecoolwinter thecoolwinter marked this pull request as ready for review September 15, 2025 15:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
macOS Tahoe Issues for macOS Tahoe
Projects
None yet
Development

Successfully merging this pull request may close these issues.

✨ XCode 26 style tabview
2 participants