Skip to content

Conversation

thecoolwinter
Copy link
Collaborator

@thecoolwinter thecoolwinter commented Aug 25, 2025

Description

Generally improves a few UX bugs with the suggestion window. Specifically the window would flash often even if the controller did not re-request new items, and would sometimes move the window when it shouldn't have. Also adjusts the window's x position to align the completion labels with the text.

  • Centralizes suggestion presentation logic into a single class.
  • Moves the trigger character logic out of a filter and into a textview delegate-like method that checks if the last typed character was a trigger character.
    • Ensures the textview and cursor positions are up-to-date when the notification is sent.
  • Helps remove duplicate cursor update notifications sent to the suggestion controller by checking if an update is a duplicate in the centralized logic controller.
  • Adjusts the suggestion window's x position to align the text in the completion labels with the text being typed.

Also includes a few changes fixing some build warnings.

Related Issues

Checklist

  • I read and understood the contributing guide as well as the code of conduct
  • The issues this PR addresses are related to each other
  • My changes generate no new warnings
  • My code builds and runs on my machine
  • My changes are all related to the related issue above
  • I documented my code

Screenshots

Screen.Recording.2025-08-25.at.12.32.40.PM.mov

@thecoolwinter thecoolwinter added the bug Something isn't working label Aug 25, 2025
nkleemann added a commit to nkleemann/CodeEditSourceEditor that referenced this pull request Aug 27, 2025
@thecoolwinter thecoolwinter merged commit 424453d into CodeEditApp:main Aug 27, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants