Ignore spurious canExecute changes #49
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
canExecute is frequently set to a truthy value e.g. !isExecuting && order() && order().amount() > 0. Knockout dependancy triggers updating this whenever any of the observables changes resulting in spurious updates to subscribers e.g. Activity. Coerce to a boolean to ignore spurious updates
|
I hadn't noticed this problem myself, but the change makes sense to me |
|
Only noticed this while deep debugging another issue. Many canExecute delegates have dependancies on an entire model (e.g. order) and as a result every change to the model triggers a truthy update to subscribers regardless of the boolean value |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
canExecute is frequently set to a truthy value e.g. !isExecuting &&
order() && order().amount() > 0.
Knockout dependancy triggers updating canExecute whenever any of the observables changes resulting in spurious updates to subscribers e.g. Activity.
Coerce canExecuteDelegate value to a boolean to ignore spurious updates being pushed to subscribers