Skip to content

London | 25-SDC-July | Eyuel Abraham | Sprint1 | Analyse and Refactor #26

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
eyuell21 wants to merge 4 commits into
base: main
Choose a base branch
from
Open

London | 25-SDC-July | Eyuel Abraham | Sprint1 | Analyse and Refactor #26

eyuell21 wants to merge 4 commits into from

Conversation

@eyuell21
Copy link

@eyuell21 eyuell21 commented Oct 3, 2025 •
edited
Loading

Learners, PR Template

Self checklist

  • I have titled my PR with Region | Cohort | FirstName LastName | Sprint | Assignment Title
  • My changes meet the requirements of the task
  • I have tested my changes
  • My changes follow the style guide

Changelist

I have tried to calculate the Time and Space Complexity of the given functions and tried to add Optimal ways to improve the functions both in python and Js.
I have Used resources like youTube and developer.mozilla.org.

Questions

No questions.

@eyuell21 eyuell21 added the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Oct 3, 2025
@github-actions
Copy link

github-actions bot commented Oct 3, 2025

Your PR couldn't be matched to an assignment in this module.

Please check its title is in the correct format, and that you only have one PR per assignment.

If this PR is not coursework, please add the NotCoursework label (and message on Slack in #cyf-curriculum or it will probably not be noticed).

1 similar comment
@github-actions
Copy link

github-actions bot commented Oct 3, 2025

Your PR couldn't be matched to an assignment in this module.

Please check its title is in the correct format, and that you only have one PR per assignment.

If this PR is not coursework, please add the NotCoursework label (and message on Slack in #cyf-curriculum or it will probably not be noticed).

@eyuell21 eyuell21 changed the title London | 25-SDC-July | Eyuel Abraham | Sprint 1 | Module-Complexity London | 25-SDC-July | Eyuel Abraham | Module-Complexity | Sprint-1 Oct 10, 2025
@github-actions
Copy link

github-actions bot commented Oct 10, 2025

Your PR couldn't be matched to an assignment in this module.

Please check its title is in the correct format, and that you only have one PR per assignment.

If this PR is not coursework, please add the NotCoursework label (and message on Slack in #cyf-curriculum or it will probably not be noticed).

@eyuell21 eyuell21 changed the title London | 25-SDC-July | Eyuel Abraham | Module-Complexity | Sprint-1 London | 25-SDC-July | Eyuel Abraham | Sprint-1 | Analyse and Refactor Functions Oct 10, 2025
@github-actions
Copy link

github-actions bot commented Oct 10, 2025

Your PR's title isn't in the expected format.

Please check the expected title format, and update yours to match.

Reason: Sprint part (Sprint-1) doesn't match expected format (example: 'Sprint 2', without quotes)

If this PR is not coursework, please add the NotCoursework label (and message on Slack in #cyf-curriculum or it will probably not be noticed).

@eyuell21 eyuell21 removed the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Oct 10, 2025
@github-actions
Copy link

github-actions bot commented Oct 10, 2025

Your PR's title isn't in the expected format.

Please check the expected title format, and update yours to match.

Reason: Sprint part (Sprint-1) doesn't match expected format (example: 'Sprint 2', without quotes)

If this PR is not coursework, please add the NotCoursework label (and message on Slack in #cyf-curriculum or it will probably not be noticed).

5 similar comments
@github-actions
Copy link

github-actions bot commented Oct 15, 2025

Your PR's title isn't in the expected format.

Please check the expected title format, and update yours to match.

Reason: Sprint part (Sprint-1) doesn't match expected format (example: 'Sprint 2', without quotes)

If this PR is not coursework, please add the NotCoursework label (and message on Slack in #cyf-curriculum or it will probably not be noticed).

@github-actions
Copy link

github-actions bot commented Oct 15, 2025

Your PR's title isn't in the expected format.

Please check the expected title format, and update yours to match.

Reason: Sprint part (Sprint-1) doesn't match expected format (example: 'Sprint 2', without quotes)

If this PR is not coursework, please add the NotCoursework label (and message on Slack in #cyf-curriculum or it will probably not be noticed).

@github-actions
Copy link

github-actions bot commented Oct 15, 2025

Your PR's title isn't in the expected format.

Please check the expected title format, and update yours to match.

Reason: Sprint part (Sprint-1) doesn't match expected format (example: 'Sprint 2', without quotes)

If this PR is not coursework, please add the NotCoursework label (and message on Slack in #cyf-curriculum or it will probably not be noticed).

@github-actions
Copy link

github-actions bot commented Oct 15, 2025

Your PR's title isn't in the expected format.

Please check the expected title format, and update yours to match.

Reason: Sprint part (Sprint-1) doesn't match expected format (example: 'Sprint 2', without quotes)

If this PR is not coursework, please add the NotCoursework label (and message on Slack in #cyf-curriculum or it will probably not be noticed).

@github-actions
Copy link

github-actions bot commented Oct 15, 2025

Your PR's title isn't in the expected format.

Please check the expected title format, and update yours to match.

Reason: Sprint part (Sprint-1) doesn't match expected format (example: 'Sprint 2', without quotes)

If this PR is not coursework, please add the NotCoursework label (and message on Slack in #cyf-curriculum or it will probably not be noticed).

@eyuell21 eyuell21 added 📅 Sprint 1 Assigned during Sprint 1 of this module Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. Module-Complexity The name of the module. labels Oct 15, 2025
@github-actions
Copy link

github-actions bot commented Oct 15, 2025

Your PR's title isn't in the expected format.

Please check the expected title format, and update yours to match.

Reason: Sprint part (Sprint-1) doesn't match expected format (example: 'Sprint 2', without quotes)

If this PR is not coursework, please add the NotCoursework label (and message on Slack in #cyf-curriculum or it will probably not be noticed).

2 similar comments
@github-actions
Copy link

github-actions bot commented Oct 15, 2025

Your PR's title isn't in the expected format.

Please check the expected title format, and update yours to match.

Reason: Sprint part (Sprint-1) doesn't match expected format (example: 'Sprint 2', without quotes)

If this PR is not coursework, please add the NotCoursework label (and message on Slack in #cyf-curriculum or it will probably not be noticed).

@github-actions
Copy link

github-actions bot commented Oct 15, 2025

Your PR's title isn't in the expected format.

Please check the expected title format, and update yours to match.

Reason: Sprint part (Sprint-1) doesn't match expected format (example: 'Sprint 2', without quotes)

If this PR is not coursework, please add the NotCoursework label (and message on Slack in #cyf-curriculum or it will probably not be noticed).

@eyuell21 eyuell21 changed the title London | 25-SDC-July | Eyuel Abraham | Sprint-1 | Analyse and Refactor Functions London | 25-SDC-July | Eyuel Abraham | Sprint-1 | Analyse and Refactor Oct 15, 2025
@github-actions
Copy link

github-actions bot commented Oct 15, 2025

Your PR's title isn't in the expected format.

Please check the expected title format, and update yours to match.

Reason: Sprint part (Sprint-1) doesn't match expected format (example: 'Sprint 2', without quotes)

If this PR is not coursework, please add the NotCoursework label (and message on Slack in #cyf-curriculum or it will probably not be noticed).

@Droid-An
Copy link

Droid-An commented Oct 20, 2025

As part of the 04 Analyse and Refactor Functions backlog issue, I've reviewed your solutions, and everything looks good. The only suggestion I have is to remove the - symbol from Sprint-1 in your PR title.

@eyuell21 eyuell21 changed the title London | 25-SDC-July | Eyuel Abraham | Sprint-1 | Analyse and Refactor London | 25-SDC-July | Eyuel Abraham | Sprint1 | Analyse and Refactor Oct 23, 2025
@github-actions
Copy link

github-actions bot commented Oct 23, 2025

Your PR's title isn't in the expected format.

Please check the expected title format, and update yours to match.

Reason: Sprint part (Sprint1) doesn't match expected format (example: 'Sprint 2', without quotes)

If this PR is not coursework, please add the NotCoursework label (and message on Slack in #cyf-curriculum or it will probably not be noticed).

@eyuell21
Copy link
Author

eyuell21 commented Oct 23, 2025

As part of the 04 Analyse and Refactor Functions backlog issue, I've reviewed your solutions, and everything looks good. The only suggestion I have is to remove the - symbol from Sprint-1 in your PR title.

Hello! @Droid-An Thank you for the review, I have made the requested changes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

Module-Complexity The name of the module. Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. 📅 Sprint 1 Assigned during Sprint 1 of this module

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@eyuell21 @Droid-An