London | 25-SDC-July | Ali Qassab | Sprint 1 | Analyse and Refactor Functions #43
Conversation
|
Your PR couldn't be matched to an assignment in this module. Please check its title is in the correct format, and that you only have one PR per assignment. If this PR is not coursework, please add the NotCoursework label (and message on Slack in #cyf-curriculum or it will probably not be noticed). |
AliQassab
added
the
Needs Review
|
Your PR couldn't be matched to an assignment in this module. Please check its title is in the correct format, and that you only have one PR per assignment. If this PR is not coursework, please add the NotCoursework label (and message on Slack in #cyf-curriculum or it will probably not be noticed). |
AliQassab
changed the title
|
Your PR couldn't be matched to an assignment in this module. Please check its title is in the correct format, and that you only have one PR per assignment. If this PR is not coursework, please add the NotCoursework label (and message on Slack in #cyf-curriculum or it will probably not be noticed). |
AliQassab
changed the title
|
Your PR description contained template fields which weren't filled in. Check you've ticked everything in the self checklist, and that any sections which prompt you to fill in an answer are either filled in or removed. If this PR is not coursework, please add the NotCoursework label (and message on Slack in #cyf-curriculum or it will probably not be noticed). |
1 similar comment
|
Your PR description contained template fields which weren't filled in. Check you've ticked everything in the self checklist, and that any sections which prompt you to fill in an answer are either filled in or removed. If this PR is not coursework, please add the NotCoursework label (and message on Slack in #cyf-curriculum or it will probably not be noticed). |
|
Your PR couldn't be matched to an assignment in this module. Please check its title is in the correct format, and that you only have one PR per assignment. If this PR is not coursework, please add the NotCoursework label (and message on Slack in #cyf-curriculum or it will probably not be noticed). |
|
Your PR description contained template fields which weren't filled in. Check you've ticked everything in the self checklist, and that any sections which prompt you to fill in an answer are either filled in or removed. If this PR is not coursework, please add the NotCoursework label (and message on Slack in #cyf-curriculum or it will probably not be noticed). |
1 similar comment
|
Your PR description contained template fields which weren't filled in. Check you've ticked everything in the self checklist, and that any sections which prompt you to fill in an answer are either filled in or removed. If this PR is not coursework, please add the NotCoursework label (and message on Slack in #cyf-curriculum or it will probably not be noticed). |
AliQassab
added
🏕 Priority Mandatory
|
Your PR description contained template fields which weren't filled in. Check you've ticked everything in the self checklist, and that any sections which prompt you to fill in an answer are either filled in or removed. If this PR is not coursework, please add the NotCoursework label (and message on Slack in #cyf-curriculum or it will probably not be noticed). |
2 similar comments
|
Your PR description contained template fields which weren't filled in. Check you've ticked everything in the self checklist, and that any sections which prompt you to fill in an answer are either filled in or removed. If this PR is not coursework, please add the NotCoursework label (and message on Slack in #cyf-curriculum or it will probably not be noticed). |
|
Your PR description contained template fields which weren't filled in. Check you've ticked everything in the self checklist, and that any sections which prompt you to fill in an answer are either filled in or removed. If this PR is not coursework, please add the NotCoursework label (and message on Slack in #cyf-curriculum or it will probably not be noticed). |
AliQassab
force-pushed
the
Learning-Objectives
branch
from
e7ca433 to
786f8a9
Compare
- JavaScript: calculateSumAndProduct, findCommonItems, hasPairWithSum, removeDuplicates - Python: calculate_sum_and_product, find_common_items, has_pair_with_sum, remove_duplicates - Reduced complexity from O(n²) to O(n) and O(n×m) to O(n+m) - Performance improvements: 50x to 1000x faster for large inputs
AliQassab
force-pushed
the
Learning-Objectives
branch
from
786f8a9 to
9ed252d
Compare
1 participant
Learners, PR Template
Self checklist
Changelist
Optimized 8 functions across JavaScript and Python implementations:
JavaScript (4 functions):
calculateSumAndProduct: 2n → n operations (50% improvement)findCommonItems: O(n×m) → O(n+m) complexity (500x faster)hasPairWithSum: O(n²) → O(n) complexity (1000x faster)removeDuplicates: O(n²) → O(n) complexity (500x faster)Python (4 functions):
calculate_sum_and_product: 2n → n operations (50% improvement)find_common_items: O(n×m) → O(n+m) complexity (500x faster)has_pair_with_sum: O(n²) → O(n) complexity (1000x faster)remove_duplicates: O(n²) → O(n) complexity (500x faster)Key improvements:
Questions
Ask any questions you have for your reviewer.