ITPJ25LDN | Eyuel Abraham | Data-flows book library | week 2#162
Closed
eyuell21 wants to merge 4 commits intoCodeYourFuture:mainfrom
Closed
ITPJ25LDN | Eyuel Abraham | Data-flows book library | week 2#162eyuell21 wants to merge 4 commits intoCodeYourFuture:mainfrom
eyuell21 wants to merge 4 commits intoCodeYourFuture:mainfrom
Conversation
Added a title to the page.
eyuell21
added
📅 Sprint 2
halilibrahimcelik
added
Review in progress
halilibrahimcelik
suggested changes
Mar 22, 2025
halilibrahimcelik
left a comment
halilibrahimcelik
left a comment
There was a problem hiding this comment.
I made a few comments, please refer to them. apart from that everything seems to be okay, keep up the good work.
| let book = new Book(title.value, author.value, pages.value, check.checked); | ||
| myLibrary.push(book); | ||
| render(); | ||
| } |
There was a problem hiding this comment.
I'm still able to add a book even if one field is empty
Author
There was a problem hiding this comment.
I have fixed the issue, thank you for the review.
| let readStatus = ""; | ||
| if (myLibrary[i].check == false) { | ||
| readStatus = "Yes"; | ||
| readStatus = "NO"; |
There was a problem hiding this comment.
If you don't read a book, color of button shouldn't be green, maybe we should change to something else in order to increase user experience.
Author
There was a problem hiding this comment.
I have added a RED background colour when readStatus = "NO";
…ed to the button when "read status " is "NO".
halilibrahimcelik
approved these changes
Apr 3, 2025
halilibrahimcelik
added
Reviewed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Learners, PR Template
Self checklist
Changelist
Briefly explain your PR.
Fixed the issues mentioned in the readme file.
Questions
Ask any questions you have for your reviewer.