Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LONDON-JAN-25 | ANDREI FILIPPOV | Module-Data Flows | WEEK 2 Feature/book-library #163

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

Droid-An
Copy link

@Droid-An Droid-An commented Mar 20, 2025

Learners, PR Template

Self checklist

  • I have committed my files one by one, on purpose, and for a reason
  • I have titled my PR with COHORT_NAME | FIRST_NAME LAST_NAME | REPO_NAME | WEEK
  • I have tested my changes
  • My changes follow the style guide
  • My changes meet the requirements of this task

Changelist

fixed bug in book library app

Questions

no questions

@Droid-An Droid-An added the Needs Review Participant to add when requesting review label Mar 20, 2025
@jenny-alexander jenny-alexander self-requested a review April 6, 2025 21:50
@jenny-alexander jenny-alexander added Review in progress This review is currently being reviewed. This label will be replaced by "Reviewed" soon. and removed Needs Review Participant to add when requesting review labels Apr 6, 2025
Copy link

@jenny-alexander jenny-alexander left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You fixed all of the problems outlined in the requirements. It works well now. However, there are a few more changes you implement to make your code even better:

  1. The browser tab currently shows '127.0.0.1:555/debugging/book-library. Can you update it to be more explanatory to the user. If you want to read more about this here is a doc: https://developer.mozilla.org/en-US/docs/Web/HTML/Element/title

  2. Can you review all of the places that you declared a variable with 'let'? In general, you will mostly always use const (and this should be your default). If you need to reassign a value to the variable, then you would use let. Here is a video you can watch: https://youtu.be/RE6qf3As-XU?si=_YaiEPeBC5Cx_j56

  3. There are a few places where the variable name was not clear to me. For example, using 'but' to denote a button might be confusing to someone reviewing your code. Can you replace with a better name where you used 'but'? 🙂.

  4. Should the code-reading/readme.md file be included in this PR?

@jenny-alexander jenny-alexander added Reviewed Volunteer to add when completing a review and removed Review in progress This review is currently being reviewed. This label will be replaced by "Reviewed" soon. labels Apr 7, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Reviewed Volunteer to add when completing a review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants