Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LON | Amir Montazeri | Module-Data-Flows | Book-Library #165

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

Amirmontazerii
Copy link

@Amirmontazerii Amirmontazerii commented Mar 22, 2025

Learners, PR Template

Self checklist

  • I have committed my files one by one, on purpose, and for a reason
  • I have titled my PR with COHORT_NAME | FIRST_NAME LAST_NAME | REPO_NAME | WEEK
  • I have tested my changes
  • My changes follow the style guide
  • My changes meet the requirements of this task

Changelist

Briefly explain your PR.

Questions

Ask any questions you have for your reviewer.

@Amirmontazerii Amirmontazerii added the Needs Review Participant to add when requesting review label Mar 22, 2025
@jenny-alexander jenny-alexander self-requested a review April 7, 2025 02:27
@jenny-alexander jenny-alexander added Review in progress This review is currently being reviewed. This label will be replaced by "Reviewed" soon. and removed Needs Review Participant to add when requesting review labels Apr 7, 2025
Copy link

@jenny-alexander jenny-alexander left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job fixing the bugs - the application is working well now.
You also did a good job replacing the 'let' variables with 'const'. 👏

Please make the following changes to make your code even better.

  • The browser tab currently shows '127.0.0.1:555/debugging/book-library. Can you update it to be more explanatory to the user. If you want to read more about this here is a doc: https://developer.mozilla.org/en-US/docs/Web/HTML/Element/title

  • The changelist portion of your pull request is currently empty. This is an important part that helps other engineers understand what you've modified.
    Could you please add a brief description of your changes in the changelist section? Even a simple summary is will be beneficial.


// Read/Unread Toggle Button
const changeBut = document.createElement("button");

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's possible that using changeBut to denote a button might be confusing to someone reviewing your code. Can you replace with a clearer name here and at line 86? Here are some tips:

  • it's recommended to start with a verb for functions
  • it's okay to use btn to shorten button. Personally, I use 'button' to be clear

@jenny-alexander jenny-alexander added Reviewed Volunteer to add when completing a review and removed Review in progress This review is currently being reviewed. This label will be replaced by "Reviewed" soon. labels Apr 7, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Reviewed Volunteer to add when completing a review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants