ITP-JAN-25 | WM| Hatef Eidi | Module-Data-Flows | Array Destructuring | Week-1 #167
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…der along with their quantity, name and price
HatefEidi
added
📅 Sprint 1
jenny-alexander
added
Review in progress
| return hogwarts.filter(({ house }) => house === "Gryffindor") | ||
| .map(({ firstName, lastName }) => `${firstName} ${lastName}`); | ||
| } | ||
| console.log(gryffindorMembers(hogwarts)); |
There was a problem hiding this comment.
nit: I would output text explaining what the output is.
console.log('Gryffindor members are:', gryffindorMembers(hogwarts)).
| return hogwarts.filter(({ occupation, pet }) => occupation === "Teacher" && pet) | ||
| .map(({ firstName, lastName }) => `${firstName} ${lastName}`); | ||
| } | ||
| console.log(teachersWithPets(hogwarts)); |
There was a problem hiding this comment.
nit: I would output text explaining what the output is.
console.log('Teachers with pets are:', teachersWithPets(hogwarts)).
| @@ -6,7 +6,7 @@ const personOne = { | |||
|
|
|||
| // Update the parameter to this function to make it work. | |||
| // Don't change anything else. | |||
| function introduceYourself(___________________________) { | |||
| function introduceYourself( { name, age, favouriteFood }=personOne) { | |||
There was a problem hiding this comment.
Nit: Try to keep spacing consistent throughout your code. It makes it easier to read and maintain. 🙂
function introduceYourself( { name, age, favouriteFood } = personOne )
| `${quantity.toString().padEnd(7)} ${itemName.padEnd(21)} £${totalItem.toFixed(2)}` | ||
| ); | ||
| }) | ||
| console.log(`Total: ${total.toFixed(2)}`) |
There was a problem hiding this comment.
The readme required output different than what your PR is showing:
- The readme does not have the '----------' under the column headers.
- The readme file shows a space between the last item and the final total. Can you make this small change?
- The readme does not show the item.length being output. Can you update your code to reflect the expected result from the readme?
jenny-alexander
suggested changes
Apr 20, 2025
jenny-alexander
added
Needs Review
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Learners, PR Template
Self checklist
Changelist
Destructuring arrays and objects
Questions
Ask any questions you have for your reviewer.