Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ITP_JAN25| Sheetal_Kharab | Module_Data_flows| Book_Library #170

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

ITP_JAN25| Sheetal_Kharab | Module_Data_flows| Book_Library #170

wants to merge 1 commit into from

Conversation

sheetalkharab
Copy link

Learners, PR Template

Self checklist

  • I have committed my files one by one, on purpose, and for a reason
  • I have titled my PR with COHORT_NAME | FIRST_NAME LAST_NAME | REPO_NAME | WEEK
  • I have tested my changes
  • My changes follow the style guide
  • My changes meet the requirements of this task

Changelist

find some bug and update code and fix delete button

Questions

Ask any questions you have for your reviewer.

@sheetalkharab sheetalkharab linked an issue Mar 25, 2025 that may be closed by this pull request
[TECH ED] Book Library sheetalkharab/My-Coursework-Planner#113
Open
@sheetalkharab sheetalkharab added the Needs Review Participant to add when requesting review label Mar 25, 2025
shieldo
shieldo approved these changes Apr 6, 2025
View reviewed changes
Copy link

@shieldo shieldo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well done @sheetalkharab - you've made all the fixes here so the script runs without errors and doesn't have the buggy behaviour that it started with - everything listed is fixed!

@shieldo shieldo added Reviewed Volunteer to add when completing a review and removed Needs Review Participant to add when requesting review labels Apr 6, 2025
@sheetalkharab sheetalkharab added Complete Participant to add when work is complete and review comments have been addressed and removed Complete Participant to add when work is complete and review comments have been addressed labels Apr 6, 2025
@sheetalkharab
Copy link
Author

Hello @shieldo, Thank you for review. Sorry, I changed the label without asking. so I just removed it and please suggest, can I change label to 'complete' .

@shieldo
Copy link

shieldo commented Apr 6, 2025 via email

@sheetalkharab
Copy link
Author

@shieldo ,Thank you

@sheetalkharab sheetalkharab added the Complete Participant to add when work is complete and review comments have been addressed label Apr 6, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shieldo shieldo shieldo approved these changes

Assignees
No one assigned
Labels
Complete Participant to add when work is complete and review comments have been addressed Reviewed Volunteer to add when completing a review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[TECH ED] Book Library
2 participants
@sheetalkharab @shieldo