Skip to content

ITP-JAN|LONDON|FOROGH AGHAEIYARIJANI|BOOK LIBRARY PROJECT|WEE 2|problem solution #174

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 5 commits into
base: main
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
72 changes: 17 additions & 55 deletions debugging/book-library/index.html
Original file line number Diff line number Diff line change
@@ -1,19 +1,13 @@
<!DOCTYPE html>
<html>
<html lang="en">
<head>
<title> </title>
<meta
charset="utf-8"
name="viewport"
content="width=device-width, initial-scale=1.0"
/>
<title>My Book Library</title>
<meta charset="utf-8" />
<meta name="viewport" content="width=device-width, initial-scale=1.0" />
<script src="https://ajax.googleapis.com/ajax/libs/jquery/3.4.1/jquery.min.js"></script>
<script src="https://cdnjs.cloudflare.com/ajax/libs/popper.js/1.16.0/umd/popper.min.js"></script>
<script src="https://maxcdn.bootstrapcdn.com/bootstrap/4.4.1/js/bootstrap.min.js"></script>
<link
rel="stylesheet"
href="https://maxcdn.bootstrapcdn.com/bootstrap/4.4.1/css/bootstrap.min.css"
/>
<link rel="stylesheet" href="https://maxcdn.bootstrapcdn.com/bootstrap/4.4.1/css/bootstrap.min.css" />
<link rel="stylesheet" type="text/css" href="style.css" />
</head>

Expand All @@ -23,50 +17,24 @@ <h1>Library</h1>
<p>Add books to your virtual library</p>
</div>

<button data-toggle="collapse" data-target="#demo" class="btn btn-info">
Add new book
</button>
<button data-toggle="collapse" data-target="#demo" class="btn btn-info">Add new book</button>

<div id="demo" class="collapse">
<div class="form-group">
<label for="title">Title:</label>
<input
type="title"
class="form-control"
id="title"
name="title"
required
/>
<label for="author">Author: </label>
<input
type="author"
class="form-control"
id="author"
name="author"
required
/>
<input type="text" class="form-control" id="title" name="title" required />

<label for="author">Author:</label>
<input type="text" class="form-control" id="author" name="author" required />

<label for="pages">Pages:</label>
<input
type="number"
class="form-control"
id="pages"
name="pages"
required
/>
<input type="number" class="form-control" id="pages" name="pages" required />

<label class="form-check-label">
<input
type="checkbox"
class="form-check-input"
id="check"
value=""
/>Read
<input type="checkbox" class="form-check-input" id="check" /> Read
</label>
<input
type="submit"
value="Submit"
class="btn btn-primary"
onclick="submit();"
/>

<input type="button" value="Submit" class="btn btn-primary" onclick="submit();" />
</div>
</div>

Expand All @@ -81,13 +49,7 @@ <h1>Library</h1>
</tr>
</thead>
<tbody>
<tr>
<td></td>
<td></td>
<td></td>
<td></td>
<td></td>
</tr>

</tbody>
</table>

Expand Down
100 changes: 41 additions & 59 deletions debugging/book-library/script.js

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are 2 other let variables that should be changed to const since they are not being reassigned. Can you find them and make the change please?

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I did it.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Still one more left. :)

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I thought I should use Let for array. Thanks, that's it.

Original file line number Diff line number Diff line change
@@ -1,45 +1,34 @@
let myLibrary = [];

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is an example of a variable that should be declared as a const.
There are other variables within script.js that are declared as let but should be const.
➡️ Can you find them and change them?
Using const prevents accidental reassignment of the variable and makes your code easier to read.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes,I did it.


window.addEventListener("load", function (e) {
window.addEventListener("load", function () {
populateStorage();
render();
});

function populateStorage() {
if (myLibrary.length == 0) {
let book1 = new Book("Robison Crusoe", "Daniel Defoe", "252", true);
let book2 = new Book(
"The Old Man and the Sea",
"Ernest Hemingway",
"127",
true
);
if (myLibrary.length === 0) {
let book1 = new Book("Robinson Crusoe", "Daniel Defoe", "252", true);
let book2 = new Book("The Old Man and the Sea", "Ernest Hemingway", "127", true);
myLibrary.push(book1);
myLibrary.push(book2);
render();
}
render();
}

const title = document.getElementById("title");
const author = document.getElementById("author");
const pages = document.getElementById("pages");
const check = document.getElementById("check");

//check the right input from forms and if its ok -> add the new book (object in array)
//via Book function and start render function
function submit() {
if (
title.value == null ||
title.value == "" ||
pages.value == null ||
pages.value == ""
) {
if (!title.value || !author.value || !pages.value) {
alert("Please fill all fields!");
return false;
} else {
let book = new Book(title.value, title.value, pages.value, check.checked);
library.push(book);
let book = new Book(title.value, author.value, pages.value, check.checked);
myLibrary.push(book);
render();
clearForm();
}
}

Expand All @@ -53,51 +42,44 @@ function Book(title, author, pages, check) {
function render() {
let table = document.getElementById("display");
let rowsNumber = table.rows.length;
//delete old table
for (let n = rowsNumber - 1; n > 0; n-- {


for (let n = rowsNumber - 1; n > 0; n--) {
table.deleteRow(n);
}
//insert updated row and cells
let length = myLibrary.length;
for (let i = 0; i < length; i++) {
let row = table.insertRow(1);
let titleCell = row.insertCell(0);
let authorCell = row.insertCell(1);
let pagesCell = row.insertCell(2);
let wasReadCell = row.insertCell(3);
let deleteCell = row.insertCell(4);
titleCell.innerHTML = myLibrary[i].title;
authorCell.innerHTML = myLibrary[i].author;
pagesCell.innerHTML = myLibrary[i].pages;

//add and wait for action for read/unread button
let changeBut = document.createElement("button");
changeBut.id = i;
changeBut.className = "btn btn-success";
wasReadCell.appendChild(changeBut);
let readStatus = "";
if (myLibrary[i].check == false) {
readStatus = "Yes";
} else {
readStatus = "No";
}
changeBut.innerText = readStatus;

changeBut.addEventListener("click", function () {
myLibrary[i].check = !myLibrary[i].check;

myLibrary.forEach((book, i) => {
let row = table.insertRow();
row.insertCell(0).innerText = book.title;
row.insertCell(1).innerText = book.author;
row.insertCell(2).innerText = book.pages;


let readButton = document.createElement("button");
readButton.className = "btn btn-success";
readButton.innerText = book.check ? "Yes" : "No";
readButton.addEventListener("click", () => {
book.check = !book.check;
render();
});

//add delete button to every row and render again
row.insertCell(3).appendChild(readButton);


let delButton = document.createElement("button");
delBut.id = i + 5;
deleteCell.appendChild(delBut);
delBut.className = "btn btn-warning";
delBut.innerHTML = "Delete";
delBut.addEventListener("clicks", function () {
alert(`You've deleted title: ${myLibrary[i].title}`);
delButton.className = "btn btn-warning";
delButton.innerText = "Delete";
delButton.addEventListener("click", () => {
alert(`You've deleted title: ${book.title}`);
myLibrary.splice(i, 1);
render();
});
}
row.insertCell(4).appendChild(delButton);
});
}

function clearForm() {
title.value = "";
author.value = "";
pages.value = "";
check.checked = false;
}
10 changes: 8 additions & 2 deletions debugging/book-library/style.css
Original file line number Diff line number Diff line change
@@ -1,19 +1,25 @@
.form-group {
width: 400px;
height: 300px;
align-self: left;
text-align: left;
padding-left: 20px;
}

.btn {
display: block;
width: 150px;
margin-bottom: 10px;
}

.form-check-label {
padding-left: 20px;
margin: 5px 0px 5px 0px;
margin: 5px 0;
}

button.btn-info {
margin: 20px;
}

.table button {
margin-right: 5px;
}