ITP-2025-WM | Hatef-Eidi|Module-Data-Flows|Book-library | Sprint 2#180
ITP-2025-WM | Hatef-Eidi|Module-Data-Flows|Book-library | Sprint 2#180HatefEidi wants to merge 2 commits intoCodeYourFuture:mainfrom
Conversation
HatefEidi
added
the
Needs Review
| //check the right input from forms and if its ok -> add the new book (object in array) | ||
| //via Book function and start render function | ||
|
|
||
| function submit() { |
There was a problem hiding this comment.
I'm still able to add books even if fields are empty. Please check your submit logic and validation process
There was a problem hiding this comment.
Now author validation is added, all the fields must be containing something
| } else { | ||
| readStatus = "No"; | ||
| } | ||
| let readStatus = myLibrary[i].check ? "Read" : "Unread"; |
There was a problem hiding this comment.
It would be nice to see button as red if book is marked as unread to increase UI&UX
There was a problem hiding this comment.
Now added, if the book is unread it's red by adding btn-danger class to the button, Thanks for suggestion
|
|
||
| function submit() { | ||
| if ( | ||
| title.value == null || |
There was a problem hiding this comment.
Another challenge, you can also clear form fields after book is saved. Currently fields are not cleared after form submitted.
There was a problem hiding this comment.
now when a book is submitted the fields are reset
halilibrahimcelik
added
Review in progress
|
|
||
| //check the right input from forms and if its ok -> add the new book (object in array) | ||
| //via Book function and start render function | ||
|
|
There was a problem hiding this comment.
I accidentally approve your PR but your form submission validation needs to be fixed. That's why I'm leaving this comment
There was a problem hiding this comment.
No Worries, Since I completed every comment of yours I label this PR as completed
HatefEidi
added
Complete
3 participants
Learners, PR Template
Self checklist
Changelist
Briefly explain your PR.
Questions
Ask any questions you have for your reviewer.