Skip to content

ITP_LONDON | PRISCILLA_EMEBO | Module-Data-Flows | Book library #183

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 6 commits into
base: main
Choose a base branch
from
Open

ITP_LONDON | PRISCILLA_EMEBO | Module-Data-Flows | Book library #183

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
8c44300
Fixed the delete function and added the missing syntax in the render …
Priscilla-EM Apr 5, 2025
a409a7e
fixed the submit function to work properly
Priscilla-EM Apr 5, 2025
8fd9cbe
Fixed the variable name
Priscilla-EM Apr 5, 2025
c3866fb
Adjusted the if function
Priscilla-EM Apr 5, 2025
eaef660
fixed the errors in the html file
Priscilla-EM Apr 14, 2025
e4d8b81
Adjusted the function to correctly validate input and clear rows effi…
Priscilla-EM Apr 14, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
30 changes: 14 additions & 16 deletions debugging/book-library/index.html
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,20 +1,18 @@
<!DOCTYPE html>
<html>
<html lang="en">
<head>
<title> </title>
<meta
charset="utf-8"
name="viewport"
content="width=device-width, initial-scale=1.0"
/>
<title>Book Library</title>
<meta charset="utf-8">
<meta name="viewport" content="width=device-width, initial-scale=1.0">

<script src="https://ajax.googleapis.com/ajax/libs/jquery/3.4.1/jquery.min.js"></script>
<script src="https://cdnjs.cloudflare.com/ajax/libs/popper.js/1.16.0/umd/popper.min.js"></script>
<script src="https://maxcdn.bootstrapcdn.com/bootstrap/4.4.1/js/bootstrap.min.js"></script>
<link
rel="stylesheet"
href="https://maxcdn.bootstrapcdn.com/bootstrap/4.4.1/css/bootstrap.min.css"
/>
<link rel="stylesheet" type="text/css" href="style.css" />
>
<link rel="stylesheet" type="text/css" href="style.css">
</head>

<body>
Expand All @@ -31,42 +29,42 @@ <h1>Library</h1>
<div class="form-group">
<label for="title">Title:</label>
<input
type="title"
type="text"
class="form-control"
id="title"
name="title"
required
/>
>
<label for="author">Author: </label>
<input
type="author"
type="text"
class="form-control"
id="author"
name="author"
required
/>
>
<label for="pages">Pages:</label>
<input
type="number"
class="form-control"
id="pages"
name="pages"
required
/>
>
<label class="form-check-label">
<input
type="checkbox"
class="form-check-input"
id="check"
value=""
/>Read
>Read
</label>
<input
type="submit"
value="Submit"
class="btn btn-primary"
onclick="submit();"
/>
>
</div>
</div>

Expand Down
100 changes: 46 additions & 54 deletions debugging/book-library/script.js
View file
Open in desktop
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Line 71: With the way the book's title is assigned to an HTML element, a book with a title containing special character sequence such as <i> can possibly ruin the display.

Lines 77, 95:

  • Is the value assigned to these id attribute unique?
  • Is there a need to assign an id attribute to delButton?
  • Is there a need to assign an id attribute to changeBut (at line 72)?

Lines 76, 94:

  • Can you think of a more consistent way to name the variables representing the two buttons, changeBut and delButton?

Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@ window.addEventListener("load", function (e) {
});

function populateStorage() {
if (myLibrary.length == 0) {
if (myLibrary.length === 0) {
let book1 = new Book("Robison Crusoe", "Daniel Defoe", "252", true);
let book2 = new Book(
"The Old Man and the Sea",
Expand All @@ -28,76 +28,68 @@ const check = document.getElementById("check");
//check the right input from forms and if its ok -> add the new book (object in array)
//via Book function and start render function
function submit() {
if (
title.value == null ||
title.value == "" ||
pages.value == null ||
pages.value == ""
) {
// Trim the title and check if it's empty
const trimmedTitle = title.value.trim();
const trimmedAuthor = author.value.trim();

if (trimmedTitle === "" || trimmedAuthor === "" || pages.value.trim() === "") {
alert("Please fill all fields!");
return false;
} else {
let book = new Book(title.value, title.value, pages.value, check.checked);
library.push(book);
render();
}

// Validate the "pages" field so that it is always a positive integer
const pagesValue = parseInt(pages.value, 10);
if (isNaN(pagesValue) || pagesValue <= 0) {
alert("Please enter a valid number of pages!");
return false;
}

// If all fields are valid, create and add the book to the library
let book = new Book(trimmedTitle, trimmedAuthor, pages.value, check.checked);
myLibrary.push(book);
render();
}


function Book(title, author, pages, check) {
this.title = title;
this.author = author;
this.pages = pages;
this.pages = pages;
this.check = check;
}

function render() {
let table = document.getElementById("display");
let rowsNumber = table.rows.length;
//delete old table
for (let n = rowsNumber - 1; n > 0; n-- {
table.deleteRow(n);
}
//insert updated row and cells
let length = myLibrary.length;
for (let i = 0; i < length; i++) {
let row = table.insertRow(1);
let titleCell = row.insertCell(0);
let authorCell = row.insertCell(1);
let pagesCell = row.insertCell(2);
let wasReadCell = row.insertCell(3);
let deleteCell = row.insertCell(4);
titleCell.innerHTML = myLibrary[i].title;
authorCell.innerHTML = myLibrary[i].author;
pagesCell.innerHTML = myLibrary[i].pages;
const table = document.getElementById("display");
const tbody = table.getElementsByTagName("tbody")[0]; // Access the <tbody> directly

//add and wait for action for read/unread button
let changeBut = document.createElement("button");
changeBut.id = i;
changeBut.className = "btn btn-success";
wasReadCell.appendChild(changeBut);
let readStatus = "";
if (myLibrary[i].check == false) {
readStatus = "Yes";
} else {
readStatus = "No";
}
changeBut.innerText = readStatus;
// Clear all rows in tbody
tbody.innerHTML = '';

changeBut.addEventListener("click", function () {
myLibrary[i].check = !myLibrary[i].check;
myLibrary.forEach((book, index) => {
const row = tbody.insertRow();
row.insertCell(0).innerText = book.title;
row.insertCell(1).innerText = book.author;
row.insertCell(2).innerText = book.pages;

// Toggle Read Button
const toggleBtn = document.createElement("button");
toggleBtn.className = "btn btn-success";
toggleBtn.innerText = book.check ? "Yes" : "No";
toggleBtn.addEventListener("click", function () {
book.check = !book.check;
render();
});
row.insertCell(3).appendChild(toggleBtn);

//add delete button to every row and render again
let delButton = document.createElement("button");
delBut.id = i + 5;
deleteCell.appendChild(delBut);
delBut.className = "btn btn-warning";
delBut.innerHTML = "Delete";
delBut.addEventListener("clicks", function () {
alert(`You've deleted title: ${myLibrary[i].title}`);
myLibrary.splice(i, 1);
// Delete Button
const deleteBtn = document.createElement("button");
deleteBtn.className = "btn btn-warning";
deleteBtn.innerText = "Delete";
deleteBtn.addEventListener("click", function () {
alert(`You've deleted title: ${book.title}`);
myLibrary.splice(index, 1);
render();
});
}
row.insertCell(4).appendChild(deleteBtn);
});
}