West midlands/Millena Mesfin/Module-Data-Flows/Book-lLibrary/Sprint #2 #197
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cjyuan
added
Review in progress
cjyuan
reviewed
Apr 17, 2025
debugging/book-library/index.html
Outdated
There was a problem hiding this comment.
According to https://validator.w3.org/, there are errors in your index.html. Can you fix these errors?
debugging/book-library/script.js
Outdated
Comment on lines
32
to
41
| // submission handler | ||
| function submit() { | ||
| if ( | ||
| title.value == null || | ||
| title.value == "" || | ||
| pages.value == null || | ||
| author.value === "" || | ||
| parseInt(pages.value) <=0 || | ||
| isNaN(pages.value) || | ||
| pages.value == "" | ||
| ) { | ||
| ) |
There was a problem hiding this comment.
In terms of input validation,
- Can
.valuebenull? (Do we need to checksomeInputElement.value == null?) - Do you want to allow book title and author name to contain only space characters?
Currently, this is possible:
debugging/book-library/script.js
Outdated
Comment on lines
62
to
66
|
|
||
| //delete old table | ||
| for (let n = rowsNumber - 1; n > 0; n-- { | ||
| for (let n = rowsNumber - 1; n > 0; n--) { | ||
| table.deleteRow(n); | ||
| } |
There was a problem hiding this comment.
Instead of deleting the table rows one by one, can you think of a more efficient way to remove all rows (except the <th>...</th>) in the table?
There was a problem hiding this comment.
-
Lines 82, 102:
- Is the value assigned to these
idattribute unique? - Is there any need to assign an id attribute to either buttons?
- Is the value assigned to these
-
"Delete" does not work.
-
Lines 76:
- With the way the book's title is assigned to an HTML element, a book with a title containing special character sequence such as
<i>can possibly ruin the display.
- With the way the book's title is assigned to an HTML element, a book with a title containing special character sequence such as
cjyuan
added
Reviewed
Millena28
added
the
Complete
PAWEL BROILO I MODULE DATA FLOWS I BOOK LIBRARY
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Learners, PR Template
Self checklist
Changelist
Briefly explain your PR.
Questions
Ask any questions you have for your reviewer.