WESTMIDLANDS-ITP-JAN|SEGUN FOLAYAN|DATA FLOWS|BOOK-LIBRARY

[segunfolayan]

Learners, PR Template

Self checklist

• I have committed my files one by one, on purpose, and for a reason
• I have titled my PR with COHORT_NAME | FIRST_NAME LAST_NAME | REPO_NAME | WEEK
• I have tested my changes
• My changes follow the style guide
• My changes meet the requirements of this task

Changelist

BOOK LIBRARY PROJECT PR

Questions

Ask any questions you have for your reviewer.

[jenny-alexander]

Can you think of a way to rewrite lines 87-91 in order to reduce repetition?

• The value within myLibrary[i].check will hold either true or false.
• Can you use a ternary operator to achieve the same result in one line of code

The syntax of the ternary operator is like this:
condition ? trueExpression : falseExpression.
If the condition evaluates to true, the expression after the ? is executed; otherwise, the expression after the : is executed.

[segunfolayan]

readStatus = myLibrary[i].check ? "Yes" : "No";
I have replaced with this line of code.
Thank you

[jenny-alexander]

Your PR looks good 👍

Here are a few change requests that will make it even better:

1. Can you review all of the places that you declared a variable with 'let'? In general, you will mostly always use const (and this should be your default). If you need to reassign a value to the variable, then you would use let. Here is a video you can watch: https://youtu.be/RE6qf3As-XU?si=_YaiEPeBC5Cx_j56

2. The 4 variables on lines 24-27 are currently declared as global variables. However, they are only used within the submit function.
   Can modify your code so that they are no longer global variables and are declared as local variables?
   Making this change means the variables won't be created until they are needed within the submit function. This makes the code cleaner and more maintainable!
   https://www.w3schools.com/js/js_scope.asp

[segunfolayan]

Hello,
I will like to let you know that I have implemented the changes as advised.

1. I have used "const" to declare my variables instead of "let"
2. I have changed "title", "author", "pages" and "check" to local variables.
   Thank you.

[segunfolayan]

Thank you for your prompt and timely review.