ITP Jan 25 | Katarzyna Kazimierczuk | Data Flows | Sprint 1

[katarzynakaz]

Learners, PR Template

Self checklist

• I have committed my files one by one, on purpose, and for a reason
• I have titled my PR with COHORT_NAME | FIRST_NAME LAST_NAME | REPO_NAME | WEEK
• I have tested my changes
• My changes follow the style guide
• My changes meet the requirements of this task

Changelist

Briefly explain your PR.

Questions

Ask any questions you have for your reviewer.

[shieldo]

Generally it does look like you've understood destructuring well. There may be an issue in the first exercise when using it with function syntax - I would recommend running the exercise.js scripts to check your work. Good work generally though!

[shieldo]

When this script is now run, what happens?

There are three different parameters defined here in the function - the place where the function is called only passes in one argument, which is the personOne object. This contains fields that happen to be called name, age, and favoriteFood. Restructuring gives us a way to pass a whole object into a function, but for the function to pick out only the fields it needs, and to access them in a simple way (i.e. as name and age etc, rather than person.name and person.age which can get needlessly repetitive).

I would have a look at this section of the MDN documentation for destructuring in JavaScript, which gives some relevant examples - notice the brace ({ and }) characters inside the parentheses in the function definition. This kind of syntax is subtle, and a bit magical, but hopefully at some point it will click for you. It's definitely commonly used in JavaScript and TypeScript these days.

[katarzynakaz]

of course, it should be ({name, age, favouriteFood}), with the current one will get undefined.

[shieldo]

Close, but this doesn't need the initial personOne. We're using let to declare three variables (name, age, and favouriteFood) which are mapped from the fields with those names when the object personOne on the right hand side of the assignment operator (=) is destructured, i.e. taken apart into its constituent parts.

[katarzynakaz]

It absolutely does not! It's now corrected.

[shieldo]

When I add the lines:

console.log(sortingHat(hogwarts));
console.log(findTeachersWithPets(hogwarts));

I do get the expected output when running the file. You've used destructuring effectively here to pick out from objects only the specific fields that you need. Good stuff!

[shieldo]

It certainly is a table format :)

Usually when we have an expected format we want to follow that format - but you've done the destructuring part here fine and all the numbers are correct, so this is fine :)