ITP_JAN_25 | HASAN DEMIROZ | Data-Flows | Book-Library #217
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cjyuan
reviewed
Apr 23, 2025
There was a problem hiding this comment.
According to https://validator.w3.org/, there are errors in your index.html. Can you fix these errors?
-
Line 69:
- The current method of assigning book titles to HTML elements can cause display issues if a book title contains special character sequences such as
<i>.
- The current method of assigning book titles to HTML elements can cause display issues if a book title contains special character sequences such as
-
Lines 75, 88:
-
Are the values assigned to these
idattributes unique? -
Is there any need to assign an id attribute to either buttons?
-
Can you suggest a more consistent naming convention for the variables representing the two buttons, currently named
changeButanddelButton?
-
|
Changes look good. |
cjyuan
added
Complete
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Learners, PR Template
Self checklist
Changelist
Briefly explain your PR.
Questions
Ask any questions you have for your reviewer.