ITP-Jan| NW | Jovy So | Module-Data-Flows | Book-library

[jovyso]

Learners, PR Template

Self checklist

• I have committed my files one by one, on purpose, and for a reason
• I have titled my PR with COHORT_NAME | FIRST_NAME LAST_NAME | REPO_NAME | WEEK
• I have tested my changes
• My changes follow the style guide
• My changes meet the requirements of this task

Changelist

Briefly explain your PR.

Questions

Ask any questions you have for your reviewer.

[cjyuan]

According to https://validator.w3.org/, there are errors in your index.html. Can you fix these errors?

The code in script.js can also use some improvement.

[cjyuan]

If we call render() here, do we still need calling render() at line 5?

[cjyuan]

Instead of deleting the table rows one by one, can you think of a more efficient way to remove all rows (except the <th>...</th>) in the table?

[cjyuan]

In terms of input validation (lines 30-36),

1. Are all input properly checked?
2. Can .value be null? (Do we need to check someInputElement.value == null?)
3. Do you want to allow book title and author name to contain only space characters? For example, " ".
4. What if a user enters an invalid page number in the "pages" input field?

• Lines 70, 87:

  • Are the values assigned to these id attributes unique?
  • Is there any need to assign an id attribute to either buttons?

• Line 65:

  • The current method of assigning book titles to HTML elements can cause display issues if a title contains special character sequences like <i>.

• Can you suggest a more consistent naming convention for the variables representing the two buttons, currently named changeBut and delButton?

• Line 74-79: Can you use the conditional operator, ? : to simplify these statements into one line of code?