ITP London - May 2025 | Chi Mbah | Module Data Flows | Book Library

[Chi-Mb]

Learners, PR Template

Self checklist

• I have committed my files one by one, on purpose, and for a reason
• I have titled my PR with REGION | COHORT_NAME | FIRST_NAME LAST_NAME | PROJ_NAME
• I have tested my changes
• My changes follow the style guide
• My changes meet the requirements of this task

Changelist

Briefly explain your PR.

Questions

Ask any questions you have for your reviewer.

[cjyuan]

Code is working good when the user behaves nicely.

Here are some suggestions for you to consider:

• Lines 18-21:

  • Using descriptive and consistent suffixes for DOM elements (like El, Input, Btn, Form, etc.) can significantly improves code readability and maintainability.

• Lines 67, 77:

  • Are the values assigned to these id attributes unique?
  • Is there any need to assign an id attribute to either buttons?

• Line 62:

  • The current method of assigning book titles to HTML elements can cause display issues if a title contains special character sequences like <i>.

• When I asked ChatGPT to review your code, it gave some useful suggestions that I missed. You should try it too and see if there is anything that you can use to improve your implementation.

[cjyuan]

HTML code is error free. Good job!

[cjyuan]

I was hoping you can address all my suggestions.

[Chi-Mb]

@cjyuan Thanks for the suggestions. I've implemented them to my code