Skip to content

London | 26-ITP-Jan | Alex Okorefe | Sprint 3 | Alarm clock#1179

Open
Alex-Os-Dev-Lab wants to merge 6 commits intoCodeYourFuture:mainfrom
Alex-Os-Dev-Lab:alarm-clock
Open

London | 26-ITP-Jan | Alex Okorefe | Sprint 3 | Alarm clock#1179
Alex-Os-Dev-Lab wants to merge 6 commits intoCodeYourFuture:mainfrom
Alex-Os-Dev-Lab:alarm-clock

Conversation

@Alex-Os-Dev-Lab
Copy link
Copy Markdown

Learners, PR Template

Self checklist

  • I have titled my PR with Region | Cohort | FirstName LastName | Sprint | Assignment Title
  • My changes meet the requirements of the task
  • I have tested my changes
  • My changes follow the style guide

Changelist

Completed all task related to Alarm Clock directory

Questions

No questions for now

@Alex-Os-Dev-Lab Alex-Os-Dev-Lab added the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Apr 5, 2026
@magarpratik magarpratik added Review in progress This review is currently being reviewed. This label will be replaced by "Reviewed" soon. and removed Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. labels Apr 8, 2026
Copy link
Copy Markdown

@magarpratik magarpratik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The code is really good! 👍

I found the naming of variables and functions clear and descriptive. Also, the code is organised well making it easy to read and understand.

I've just left a couple of minor comments for you to take a look at.

Comment thread Sprint-3/alarmclock/alarmclock.js Outdated
Comment thread Sprint-3/alarmclock/alarmclock.js
@magarpratik magarpratik added Reviewed Volunteer to add when completing a review with trainee action still to take. and removed Review in progress This review is currently being reviewed. This label will be replaced by "Reviewed" soon. labels Apr 8, 2026
@Alex-Os-Dev-Lab Alex-Os-Dev-Lab added Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. and removed Reviewed Volunteer to add when completing a review with trainee action still to take. labels Apr 23, 2026
@magarpratik magarpratik added Complete Volunteer to add when work is complete and all review comments have been addressed. and removed Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. labels Apr 23, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Complete Volunteer to add when work is complete and all review comments have been addressed.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants