-
-
Notifications
You must be signed in to change notification settings - Fork 283
London | 26-ITP-Jan | Alex Okorefe | sprint 2 | coursework #1194
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
Alex-Os-Dev-Lab
wants to merge
24
commits into
CodeYourFuture:main
Choose a base branch
from
Alex-Os-Dev-Lab:sprint-2
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from 22 commits
Commits
Show all changes
24 commits
Select commit
Hold shift + click to select a range
f55cbf8
Changed the title to Alarm Clock App
Alex-Os-Dev-Lab 333486d
Revert title to default in index.html
Alex-Os-Dev-Lab 77a4262
fixed bug in address.js and added prediction/explanation to issue
Alex-Os-Dev-Lab 5f9fc25
updated author.js to include explanation of the bug and fixed the code.
Alex-Os-Dev-Lab 6dbb61d
debugged recipe.js and explained error
Alex-Os-Dev-Lab 576cd1f
implemented function for contains.js
Alex-Os-Dev-Lab 91faef2
add tests for contains function to validate behavior with empty objec…
Alex-Os-Dev-Lab 8a037f6
implement createLookup function to map country-currency pairs
Alex-Os-Dev-Lab 4c7f534
refactor parseQueryString to improve handling of query strings and en…
Alex-Os-Dev-Lab 5b679e3
add tests for parseQueryString to cover edge cases and improve query …
Alex-Os-Dev-Lab 66e18bb
implement tally function to count occurrences of items in an array an…
Alex-Os-Dev-Lab 53bf502
add tests for tally function to validate behavior with empty arrays, …
Alex-Os-Dev-Lab 38a2a36
fix invert function to correctly swap keys and values; added initial …
Alex-Os-Dev-Lab 0ccf022
add tests for invert function to validate key-value swapping and hand…
Alex-Os-Dev-Lab 1dd6d93
reverted file back to original
Alex-Os-Dev-Lab fa2ccd3
Fix doctype declaration in index.html
Alex-Os-Dev-Lab 90faf30
Delete Sprint-3/alarmclock/index.html
Alex-Os-Dev-Lab 06aa6f5
refactor: update HTML structure for alarm clock interface
Alex-Os-Dev-Lab 914a65b
Resolve merge conflict: accept deletion of index.html
Alex-Os-Dev-Lab 2fa49ae
chore: add initial index.html for alarm clock app
Alex-Os-Dev-Lab 8ff9d81
fix: revert title in index.html to default value
Alex-Os-Dev-Lab 3292877
Fix doctype declaration in index.html
Alex-Os-Dev-Lab 74116e9
refactor: update contains function to use Object.hasOwn and initializ…
Alex-Os-Dev-Lab 5612b48
Merge branch 'sprint-2' of https://github.com/Alex-Os-Dev-Lab/Module-…
Alex-Os-Dev-Lab File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,3 +1,11 @@ | ||
| function contains() {} | ||
| function contains(obj, propertyName) { | ||
| // 1. Check if 'obj' is a valid object and NOT an array | ||
| if (typeof obj !== "object" || obj === null || Array.isArray(obj)) { | ||
| return false; | ||
| } | ||
|
|
||
| // 2. Check if the propertyName exists as a key in the object | ||
| return propertyName in obj; | ||
| } | ||
|
|
||
| module.exports = contains; | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,5 +1,14 @@ | ||
| function createLookup() { | ||
| // implementation here | ||
| function createLookup(countryCurrencyPairs) { | ||
| const lookup = {}; | ||
|
|
||
| for (const pair of countryCurrencyPairs) { | ||
| const country = pair[0]; | ||
| const currency = pair[1]; | ||
|
|
||
| lookup[country] = currency; | ||
| } | ||
|
|
||
| return lookup; | ||
| } | ||
|
|
||
| module.exports = createLookup; |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,3 +1,17 @@ | ||
| function tally() {} | ||
| function tally(items) { | ||
| // Check for valid input | ||
| if (!Array.isArray(items)) { | ||
| throw new Error("Input must be an array"); | ||
| } | ||
|
|
||
| const counts = {}; | ||
|
|
||
| for (const item of items) { | ||
| // If the item exists, increment; otherwise, initialize to 1 | ||
| counts[item] = (counts[item] || 0) + 1; | ||
| } | ||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Does the following function call returns the value you expect? Suggestion:
|
||
|
|
||
| return counts; | ||
| } | ||
|
|
||
| module.exports = tally; | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,22 @@ | ||
| const invert = require("./invert"); | ||
|
|
||
| describe("invert()", () => { | ||
| test("inverts a single key-value pair", () => { | ||
| expect(invert({ a: 1 })).toEqual({ 1: "a" }); | ||
| }); | ||
|
|
||
| test("inverts multiple key-value pairs", () => { | ||
| expect(invert({ a: 1, b: 2 })).toEqual({ 1: "a", 2: "b" }); | ||
| }); | ||
|
|
||
| test("handles an empty object", () => { | ||
| expect(invert({})).toEqual({}); | ||
| }); | ||
|
|
||
| test("inverts an object with string values", () => { | ||
| expect(invert({ first: "John", last: "Doe" })).toEqual({ | ||
| Alex: "first", | ||
| Doe: "last", | ||
| }); | ||
| }); | ||
| }); |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Consider the following two approaches for determining if an object contains a property:
Which of these approaches suits your needs better?
For more info, you can look up
JS "in" operator vs Object.hasOwn.